feat: auto-recompile the boxes and fix broken frontend CompleteAddress import #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-aztec
force-pushed
the
dan/auto-copy-box-fix
branch
from
f0720db to
452e5dd
Compare
dan-aztec
changed the title
dan-aztec
commented
Oct 9, 2023
| import { ContractAbi } from '@aztec/foundation/abi'; | ||
| import { Point } from '@aztec/foundation/fields'; |
There was a problem hiding this comment.
there was some import error with CompleteAddress inside the box frontend apps, this was the fix (same change is in a few files)
LeilaWang
requested changes
Oct 9, 2023
| if (abiImportPath === `${name}.json`) { | ||
| // relative path edge case, prepending ./ for local import - the upstream logic just does | ||
| // `${name}.json`, which is not a valid import for a file in the same directory | ||
| abiImportPath = `./${name}.json`; |
There was a problem hiding this comment.
This feels wrong. What if someone intentionally set the path to be name.json? We should find out what's calling this that should provide a relative path but didn't, and fix it there.
There was a problem hiding this comment.
thank you, did not know the imports could be configured per package. fixing
LeilaWang
reviewed
Oct 10, 2023
LeilaWang
reviewed
Oct 10, 2023
| // otherwise returning a CompleteAddress makes result undefined. | ||
| return completeAddress.toString(); | ||
| }); | ||
| // a lot of trailing 0s get added in the return value |
There was a problem hiding this comment.
Why? Is it the case for any string?
LeilaWang
approved these changes
Oct 10, 2023
dan-aztec
pushed a commit
that referenced
this pull request
Oct 10, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.9</summary> ## [0.8.9](aztec-packages-v0.8.8...aztec-packages-v0.8.9) (2023-10-10) ### Features * Auto-recompile the boxes and fix broken frontend CompleteAddress import ([#2727](#2727)) ([4ec4ea0](4ec4ea0)) ### Bug Fixes * Default export in noir-version ([#2757](#2757)) ([6ff7bed](6ff7bed)) </details> <details><summary>barretenberg.js: 0.8.9</summary> ## [0.8.9](barretenberg.js-v0.8.8...barretenberg.js-v0.8.9) (2023-10-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.9</summary> ## [0.8.9](barretenberg-v0.8.8...barretenberg-v0.8.9) (2023-10-10) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AztecBot
added a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Oct 11, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.9</summary> ## [0.8.9](AztecProtocol/aztec-packages@aztec-packages-v0.8.8...aztec-packages-v0.8.9) (2023-10-10) ### Features * Auto-recompile the boxes and fix broken frontend CompleteAddress import ([#2727](AztecProtocol/aztec-packages#2727)) ([4ec4ea0](AztecProtocol/aztec-packages@4ec4ea0)) ### Bug Fixes * Default export in noir-version ([#2757](AztecProtocol/aztec-packages#2757)) ([6ff7bed](AztecProtocol/aztec-packages@6ff7bed)) </details> <details><summary>barretenberg.js: 0.8.9</summary> ## [0.8.9](AztecProtocol/aztec-packages@barretenberg.js-v0.8.8...barretenberg.js-v0.8.9) (2023-10-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.9</summary> ## [0.8.9](AztecProtocol/aztec-packages@barretenberg-v0.8.8...barretenberg-v0.8.9) (2023-10-10) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forking prior PR to see where e2e tests failed, got in a bad state so splitting into smaller PRs.
This will help keep the boxes up to date by introducing a
bootstrap.shfor boxes, which recompiles within the monorepo using the latest localaztec-cli compilecommand.The artifact casing changes because
noir-contractscompile script does some manual changing to kebab case.--> changes box contract Nargo.toml to be buildable within monorepo by using relative paths for deps. These get updated now in the
unboxcommand.Also discovered
CompleteAddresswas broken in the frontend, Leila helped resolve import errors. added a test for the in e2e browser. This means boxes are broken on current release of our packages, so need to release again after this lands.Will do a follow up PR for reducing dependencies to just
@aztec/aztec.js, as this PR is getting big