-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto-recompile the boxes and fix broken frontend CompleteAddress import #2727
Merged
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
fecbc51
add new blank contract
dan-aztec 9f1508a
add to top level toml
dan-aztec 6c76497
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec b79f8a3
ecdsa changes
dan-aztec b4ca725
update docs test
dan-aztec e0c9575
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec 0508976
revert to local paths in box Nargo.toml and overwrite on unbox
dan-aztec 9dcc009
add support for copying noir source files in noir-contracts
dan-aztec 2c71c34
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec 61b6a8e
break link with noir-contracts
dan-aztec 8cb6af3
revert changes to noir-contracts
dan-aztec dd7a554
revert docs change
dan-aztec ce47d49
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec 8d45b54
add a bootstrap to compile files
dan-aztec d23e1d7
add boxes bootstrap to yarn bootstrap
dan-aztec f791d0d
back and forth on lint vs compiled output
dan-aztec db1bfa1
fix relative import in edge case
dan-aztec 470bb5c
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec e3d0997
update imports
dan-aztec d2b4695
typo
dan-aztec b8981ef
osx is case insensitive...
dan-aztec 651a49b
readd uppercase
dan-aztec 878008c
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec 769143d
formatting
dan-aztec e866c5e
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec 308d5e8
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec 5b31efc
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec d59e7e4
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec 903486d
turn on source maps
dan-aztec 241d435
move Point import in circuits
dan-aztec 5d81be8
add check for completeaddress in browser
dan-aztec 88a1703
revert fix to see if e2e test catches it
dan-aztec fecb80b
refix it
dan-aztec 3b3fdad
fix test and rebreak
dan-aztec b70a899
refix and see if e2e passes
dan-aztec f79844c
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec e327b53
try different test
dan-aztec f5bba47
move all Point imports to foundation
dan-aztec 50588c6
didnt realize random needed wasm
dan-aztec 4c7db71
only test this one
dan-aztec 42d49ea
Merge branch 'master' into dan/auto-copy-box-artifacts
dan-aztec eeb8d48
thanks alex for debugging e2e test
dan-aztec 452e5dd
empty log
dan-aztec 3d29209
Merge remote-tracking branch 'origin/master' into dan/auto-copy-box-fix
dan-aztec b0bbbea
fix to use local cli instead of installed aztec-cli, recompile on 0.16
dan-aztec c3cdf2c
revert change to browser headless config
dan-aztec edf9086
turn on source maps in boxes
dan-aztec 8335e9e
Merge branch 'master' into dan/auto-copy-box-fix
dan-aztec 6c19a4f
Merge branch 'master' into dan/auto-copy-box-fix
dan-aztec c636548
Merge branch 'master' into dan/auto-copy-box-fix
dan-aztec 8c9f1c9
just remove cli dep, remove others in followup
dan-aztec 10cdfdc
pr feedback
dan-aztec fb9a2d1
Merge branch 'master' into dan/auto-copy-box-fix
dan-aztec ce2e927
get string without trailing 0s
dan-aztec 79e2d4b
adjust for trailing 0s in return
dan-aztec 0b63a54
Merge branch 'master' into dan/auto-copy-box-fix
dan-aztec b6838e7
move relative path correction logic up, add to other command
dan-aztec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
yarn-project/aztec.js/src/contract_deployer/contract_deployer.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
This contains the "boxes" that are meant for quickstarts for Aztec smart contract developers, containing simple Noir smart contracts and frontends. | ||
|
||
If CI is failing, it may be due to incompatibility with previous build artifacts - running "./bootstrap.sh" inside this boxes folder should regenerate the artifacts. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 0 additions & 51 deletions
51
yarn-project/boxes/blank-react/src/artifacts/blank_contract.json
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
yarn-project/boxes/blank-react/src/tests/blank.contract.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,9 +36,6 @@ | |
{ | ||
"path": "../../circuits.js" | ||
}, | ||
{ | ||
"path": "../../cli" | ||
}, | ||
{ | ||
"path": "../../foundation" | ||
}, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 0 additions & 51 deletions
51
yarn-project/boxes/blank/src/artifacts/blank_contract.json
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,9 +36,6 @@ | |
{ | ||
"path": "../../circuits.js" | ||
}, | ||
{ | ||
"path": "../../cli" | ||
}, | ||
{ | ||
"path": "../../foundation" | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
#!/bin/bash | ||
|
||
|
||
# should be run from yarn-project/boxes | ||
original_path=$(pwd) | ||
|
||
# Loop through all directories in 'boxes' | ||
for dir in *; do | ||
# Check if it's a directory | ||
if [ -d "${dir}" ]; then | ||
|
||
# Run the compile command | ||
echo "Running compile command inside ${dir}..." | ||
|
||
# Change directory to ../cli | ||
cd ../cli | ||
|
||
# Run ts-node command to use latest "compile" code | ||
ts-node --esm src/bin/index.ts compile "${original_path}/${dir}/src/contracts" --outdir "${original_path}/${dir}/src/artifacts" --typescript "${original_path}/${dir}/src/artifacts" | ||
|
||
# Change back to the original directory | ||
cd "${original_path}" | ||
|
||
fi | ||
done |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there was some import error with
CompleteAddress
inside the box frontend apps, this was the fix (same change is in a few files)