fix: auto update contract compilation artifacts in boxes #2635
Conversation
dan-aztec
changed the title
|
Looks like we've duplicated the contract source files and are copying the artefacts from |
|
yes, that's right. should we copy the source code as well? (I didn't think those would change very often, we can copy the |
|
Maybe change the toml files in boxes to contain relative paths. We are already modifying the paths in the unbox command so it should only require small adjustment. And add a bootstrap script to boxes to rebuild the artefacts all at once. Should also try to run the compile script in CI, so that the job will fail if a contract doesn't adopt a breaking change in aztec.nr or noir. Will be great if we can make the job fail if the artefacts are not being updated. But will have to spend some time to figure out the best way to do that. |
|
ok seems reasonable. updating the Nargo.toml and added a script to copy the source code, gotta think about detection "missed recompilation" in CI |
|
The point of updating the paths in Nargo.toml is that we can just compile from there. So we don't have to copy the source code to noir-contracts and then copy it back to boxes. |
|
ah OK, I thought it was to try to do a last minute compile and check results against the copied artifacts. remove the link to |
dan-aztec
changed the title
This reverts commit f6fc7f2.
|
this one got in a really bad state re: SentTx |
…s import (#2727) [forking prior PR to see where e2e tests failed](#2635), got in a bad state so splitting into smaller PRs. This will help keep the boxes up to date by introducing a `bootstrap.sh` for boxes, which recompiles within the monorepo using the latest local `aztec-cli compile` command. The artifact casing changes because `noir-contracts` compile script does some manual changing to kebab case. --> changes box contract Nargo.toml to be buildable within monorepo by using relative paths for deps. These get updated now in the `unbox` command. Also discovered `CompleteAddress` was broken in the frontend, Leila helped resolve import errors. added a test for the in e2e browser. This means boxes are broken on current release of our packages, so need to release again after this lands. Will do a follow up PR for reducing dependencies to just `@aztec/aztec.js`, as this PR is getting big
separately build the contracts in boxes, to keep bytecode up to date as things change upstream.
slight artifact nameing change due to the difference in how
noir-contractscompilation generated artifacts, vs theaztec-cli compilecommand that box users would run locally. but, fixed the relative import bug on generated typesript classes, in the case the artifact is in the same directory!moved lingering exports to AztecJs to reduce dependencies on the frontend only apps