Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address failure cases #2493

Closed
Tracked by #2167
LHerskind opened this issue Sep 25, 2023 · 0 comments · Fixed by #2620
Closed
Tracked by #2167

Address failure cases #2493

LHerskind opened this issue Sep 25, 2023 · 0 comments · Fixed by #2620
Assignees
@rahul-kothari

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Sep 25, 2023 •
edited
Loading

Address the failure case for cross-chain communication for the uniswap aztec connect like portal. e.g., make it always fail the desired swap. Implement a way to get the funds into rollup and given back to the users.
@LHerskind LHerskind mentioned this issue Sep 25, 2023
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 25, 2023
@LHerskind LHerskind mentioned this issue Sep 25, 2023
Closed
@rahul-kothari rahul-kothari mentioned this issue Oct 2, 2023
Merged
rahul-kothari added a commit that referenced this issue Oct 6, 2023
@rahul-kothari
chore(uniswap_tests): test edge cases around uniswap flow (#2620)
7a58fe9 
Fix #2493. Part of #2167 
* Adds test cases for both public, private flow
* Found an edge case that wasn't tested in l1<>l2 tests so added those
too
* Also rename `swap` to `swap_private`

Runtime currently is ~5 mins
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul-kothari rahul-kothari

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(uniswap_tests): test edge cases around uniswap flow AztecProtocol/aztec-packages
2 participants
@LHerskind @rahul-kothari