Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NonNativeToken everywhere + update token portal #2291

Closed
Tracked by #2167
, #2177
...
rahul-kothari opened this issue Sep 14, 2023 · 0 comments · Fixed by #2723
Closed
Tracked by #2167
, #2177
...

Replace NonNativeToken everywhere + update token portal #2291

rahul-kothari opened this issue Sep 14, 2023 · 0 comments · Fixed by #2723
Assignees
@rahul-kothari

Comments

@rahul-kothari
Copy link
Contributor

rahul-kothari commented Sep 14, 2023 •
edited
Loading

  1. Replace NonNativeToken (in docs, guide and elsewhere in the codebase)
  2. Update references to TokenPortal and add relevant tests (for both public and private flow) for deposits and cancels

Part of #2167
@rahul-kothari rahul-kothari added this to A3 Sep 14, 2023
@rahul-kothari rahul-kothari converted this from a draft issue Sep 14, 2023
@rahul-kothari rahul-kothari self-assigned this Sep 14, 2023
@rahul-kothari rahul-kothari mentioned this issue Sep 14, 2023
Closed
@rahul-kothari rahul-kothari changed the title Replace NonNativeToken and crosschainharness.ts Replace NonNativeToken everywhere Sep 17, 2023
This was referenced Sep 17, 2023
Closed
Merged
@rahul-kothari rahul-kothari changed the title Replace NonNativeToken everywhere Replace NonNativeToken everywhere + update token portal Sep 18, 2023
rahul-kothari added a commit that referenced this issue Sep 19, 2023
@rahul-kothari
feat(token portal standard): Create a token portal standard (#2351)
426a3ea 
Part of #2167 - creates the tokenPortal Standard + updates cross chain
tests (and cross chain harness file)
Doc is TBD

* moved address types to aztec-nr 
* Created #2291 - where I will purge `NonNativeToken`
* In a future PR, I will update uniswap portal too. For now I have
skipped the uniswap test (to keep this PR small-ish) as it uses
`crosschainHarness` which is integral to the other cross-chain e2e tests
* I have created a separate public/private flow for depositing to Portal
(and therefore separate flow for cancelling such L1->L2 messages)
*
@rahul-kothari rahul-kothari mentioned this issue Oct 6, 2023
Merged
This was referenced Oct 11, 2023
Closed
Closed
Closed
rahul-kothari added a commit that referenced this issue Oct 12, 2023
@rahul-kothari
feat: purge non native token + reorder params in token portal (#2723)
447dade 
* Fix #2291
* Create `token_portal_content_hash_lib` folder in noir-contracts that
gets used by both token-bridge and test-contract.
* reorder params in token portal and token bridge
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 12, 2023
@Maddiaa0 Maddiaa0 removed this from A3 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul-kothari rahul-kothari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: purge non native token + reorder params in token portal AztecProtocol/aztec-packages
1 participant
@rahul-kothari