Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing ts-lib dev dependency for bb.js #1670

Closed
kevaundray opened this issue Aug 19, 2023 · 1 comment
Closed

Missing ts-lib dev dependency for bb.js #1670

kevaundray opened this issue Aug 19, 2023 · 1 comment
Labels
C-bb.js Component: bb.js - wrapping bberg in js

Comments

@kevaundray
Copy link
Contributor

## Problem

While running yarn build for the ts folder, I came across the following error:

Can't resolve 'tslib' in '/mnt/user-data/kev/aztec-packages/circuits/cpp/barretenberg/ts/src/barretenberg_wasm'

Solution

Add tsbuild to the devDependencies. We already depend on this in other packages so it does not increase the risk.

Notes
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 19, 2023
@kevaundray kevaundray mentioned this issue Aug 19, 2023
Merged
4 tasks
@iAmMichaelConnor iAmMichaelConnor added the C-bb.js Component: bb.js - wrapping bberg in js label Aug 20, 2023
@kevaundray
Copy link
Contributor Author

Closing as #1672 has been merged

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 21, 2023
codygunton pushed a commit that referenced this issue Jan 23, 2024
@PhilWindle @jonybur
Merge pull request #1678 from AztecProtocol/defi-bridge-project
40476bb 
* Copied index.html to output (#1661)

* Generate htnl file (#1662)

* Deployment fix (#1663)

* Deployment fixes (#1665)

* Deployment fix attempt (#1667)

* Updated falafel and kebab terraform with new project directory structure (#1670)

* Reduce the amount of logging in kebab (#1668)

* Reduce the amount of logging in kebab

* Logging improvement

* Bug fix

* Reverted erroneous change

* Pw/increase faucet drip (#1669)

* Increased the faucet drip size

* Force contract redeployment

* Deploy terraform from correct directory (#1671)

* JB/Website grants updates (#1666)

* Add new grant

* Improve research images

* Mini typo

* JB/Website build manifest (#1672)

* Add website to build manifest

* JB/Brand iteration (#1673)

* Small build change

* JB/Fix website deployment (#1676)

* Fix deployment

* JB/Fix website deploy (#1677)

* Fix deploy

Co-authored-by: Jonathan Bursztyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bb.js Component: bb.js - wrapping bberg in js
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevaundray @iAmMichaelConnor