Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing npm install works in the CI for bb.js #1667

Open
kevaundray opened this issue Aug 18, 2023 · 1 comment
Open

Testing npm install works in the CI for bb.js #1667

kevaundray opened this issue Aug 18, 2023 · 1 comment
Labels
C-bb.js Component: bb.js - wrapping bberg in js

Comments

@kevaundray
Copy link
Contributor

## Problem

This commit 88cd267 so that bin pointed to the correct binary script at dest/node/main.j

This fixed an issue whereby if you installed bb.js from npm, it would complain that you it could not find the main.js file at the wrong destination of dest/main.js.

Solution

One way to catch this via testing is to have a job which does npm install -g so we simulate the exact operations that a user will do
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 18, 2023
@kevaundray
Copy link
Contributor Author

Note that this was perhaps not caught because this script was changed correctly:

aztec-packages/circuits/cpp/barretenberg/acir_tests/run_bb.sh

Line 4 in 035e0d2

exec node "$DIR/../ts/dest/node/main.js" $@

@iAmMichaelConnor iAmMichaelConnor added the C-bb.js Component: bb.js - wrapping bberg in js label Aug 20, 2023
codygunton pushed a commit that referenced this issue Jan 23, 2024
@PhilWindle @jonybur
Merge pull request #1678 from AztecProtocol/defi-bridge-project
40476bb 
* Copied index.html to output (#1661)

* Generate htnl file (#1662)

* Deployment fix (#1663)

* Deployment fixes (#1665)

* Deployment fix attempt (#1667)

* Updated falafel and kebab terraform with new project directory structure (#1670)

* Reduce the amount of logging in kebab (#1668)

* Reduce the amount of logging in kebab

* Logging improvement

* Bug fix

* Reverted erroneous change

* Pw/increase faucet drip (#1669)

* Increased the faucet drip size

* Force contract redeployment

* Deploy terraform from correct directory (#1671)

* JB/Website grants updates (#1666)

* Add new grant

* Improve research images

* Mini typo

* JB/Website build manifest (#1672)

* Add website to build manifest

* JB/Brand iteration (#1673)

* Small build change

* JB/Fix website deployment (#1676)

* Fix deployment

* JB/Fix website deploy (#1677)

* Fix deploy

Co-authored-by: Jonathan Bursztyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bb.js Component: bb.js - wrapping bberg in js
Projects
A3
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevaundray @iAmMichaelConnor