feat: register-public-key & CLI update to use options instead of args #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maddiaa0
reviewed
Aug 3, 2023
| @@ -22,14 +22,27 @@ ROOT=$(pwd) | |||
|
|
|||
| write_import() { | |||
| CONTRACT_NAME=$1 | |||
| NAME=`echo $CONTRACT_NAME | sed -r 's/(^|_)(.)/\U\2/g'` | |||
|
|
|||
spypsy
changed the title
ludamad
reviewed
Aug 3, 2023
| NAME=`echo $CONTRACT_NAME | sed -r 's/(^|_)(.)/\U\2/g'` | ||
|
|
||
| if [ "$(uname)" = "Darwin" ]; then | ||
| # sed \U doesn't work on mac |
There was a problem hiding this comment.
Can't we just always use perl for simplicity?
There was a problem hiding this comment.
yep don't know why I didn't think of that 😬
benesjan
approved these changes
Aug 4, 2023
|
|
||
| - `-a, --address <aztecAddress>`: The account's Aztec address. | ||
| - `-p, --public-key <publicKey>`: 'The account public key.' | ||
| - `-pa, --partial-address <partialAddress`: 'The partially computed address of the account contract.' |
There was a problem hiding this comment.
I would link here the docs Santiago wrote about partial address etc. I feel like these terms are super confusing and I would have no idea what's going on here.
PhilWindle
requested changes
Aug 4, 2023
| With an Aztec example contract: | ||
|
|
||
| ```shell | ||
| aztec-cli deploy -c ZkTokenContractAbi -a 333 0x134567890abcdef |
There was a problem hiding this comment.
It would be great to add an additional command example-contracts that simply lists the abi names available. e.g. ZkTokenContractAbi.
…ges into sp/cli-updates
PhilWindle
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1297
Fixes #1298
Fixes #1306
Also fix issue with noir-contracts bootstrap on MacOS
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.