Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert aztec-cli arguments to options #1297

Closed
Tracked by #1294
spypsy opened this issue Jul 31, 2023 · 0 comments · Fixed by #1397
Closed
Tracked by #1294

Convert aztec-cli arguments to options #1297

spypsy opened this issue Jul 31, 2023 · 0 comments · Fixed by #1397
Assignees
@spypsy

Comments

@spypsy
Copy link
Member

spypsy commented Jul 31, 2023 •
edited
Loading

use commanderjs's requiredOption
@spypsy spypsy added this to A3 Jul 31, 2023
@spypsy spypsy converted this from a draft issue Jul 31, 2023
@spypsy spypsy self-assigned this Jul 31, 2023
@PhilWindle PhilWindle mentioned this issue Jul 31, 2023
Closed
12 tasks
@spypsy spypsy moved this from Todo to In Progress in A3 Aug 3, 2023
@spypsy spypsy mentioned this issue Aug 3, 2023
Merged
4 tasks
@spypsy spypsy moved this from In Progress to In Review in A3 Aug 3, 2023
spypsy added a commit that referenced this issue Aug 4, 2023
@spypsy
feat: register-public-key & CLI update to use options instead of args (…
d142181 
…#1397)

Fixes #1297 
Fixes #1298 
Fixes #1306 
Also fix issue with noir-contracts bootstrap on MacOS
# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spypsy spypsy

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: register-public-key & CLI update to use options instead of args AztecProtocol/aztec-packages
2 participants
@spypsy @iAmMichaelConnor