Skip to content

Commit

Permalink
chore: stop building/publishing acvm_backend.wasm (#6584)
Browse files Browse the repository at this point in the history
Noir no longer makes use of this wasm binary so we don't need to keep
building/publishing it.

Resolves #1832
  • Loading branch information
TomAFrench authored May 29, 2024
1 parent edb6db6 commit 7a3a491
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 27 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/publish-bb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,6 @@ jobs:
working-directory: barretenberg/cpp/build-wasm/bin
run: tar -cvzf barretenberg.wasm.tar.gz barretenberg.wasm

- name: Tar and GZip acvm_backend.wasm
working-directory: barretenberg/cpp/build-wasm/bin
run: tar -cvzf acvm_backend.wasm.tar.gz acvm_backend.wasm

# - name: Setup Node.js
# uses: actions/setup-node@v2
# with:
Expand All @@ -137,7 +133,6 @@ jobs:
name: release-wasm
path: |
./barretenberg/cpp/build-wasm/bin/barretenberg.wasm.tar.gz
./barretenberg/cpp/build-wasm/bin/acvm_backend.wasm.tar.gz
build-mac-intel:
name: Build on Mac x86_64-apple-darwin
Expand Down Expand Up @@ -239,7 +234,6 @@ jobs:
prerelease: true
files: |
barretenberg.wasm.tar.gz
acvm_backend.wasm.tar.gz
barretenberg-x86_64-linux-gnu.tar.gz
barretenberg-x86_64-apple-darwin.tar.gz
barretenberg-aarch64-apple-darwin.tar.gz
1 change: 0 additions & 1 deletion barretenberg/cpp/CMakePresets.json
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,6 @@
"jobs": 0,
"targets": [
"barretenberg.wasm",
"acvm_backend.wasm",
"barretenberg",
"wasi",
"env"
Expand Down
20 changes: 0 additions & 20 deletions barretenberg/cpp/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -182,30 +182,10 @@ if(WASM)
$<TARGET_OBJECTS:wasi_objects>
)

add_executable(
acvm_backend.wasm
$<TARGET_OBJECTS:wasi_objects>
$<TARGET_OBJECTS:env_objects>
$<TARGET_OBJECTS:common_objects>
$<TARGET_OBJECTS:numeric_objects>
$<TARGET_OBJECTS:ecc_objects>
$<TARGET_OBJECTS:crypto_aes128_objects>
$<TARGET_OBJECTS:crypto_blake2s_objects>
$<TARGET_OBJECTS:crypto_keccak_objects>
$<TARGET_OBJECTS:crypto_schnorr_objects>
$<TARGET_OBJECTS:crypto_pedersen_hash_objects>
$<TARGET_OBJECTS:crypto_pedersen_commitment_objects>
)

target_link_options(
barretenberg.wasm
PRIVATE
-nostartfiles -Wl,--no-entry,--export-dynamic
)

target_link_options(
acvm_backend.wasm
PRIVATE
-nostartfiles -Wl,--no-entry,--export-dynamic
)
endif()

0 comments on commit 7a3a491

Please sign in to comment.