Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove acvm_backend.wasm from barretenberg #1832

Closed
kevaundray opened this issue Aug 26, 2023 · 1 comment · Fixed by #6584
Closed

Remove acvm_backend.wasm from barretenberg #1832

kevaundray opened this issue Aug 26, 2023 · 1 comment · Fixed by #6584
Labels
C-bb.js Component: bb.js - wrapping bberg in js

Comments

@kevaundray
Copy link
Contributor

kevaundray commented Aug 26, 2023 •
edited
Loading

Problem

#1824 adds a minimal version of barretenberg.wasm that does not need proving and verifying. This can be removed in the future when the new pedersen implementation has been finished. This is a tracking issue for removing it.

Solution

Remove this module from the CmakeList.txt when the new pedersen implementation is completed and has been implemented in ACVM
@kevaundray kevaundray added the C-bb.js Component: bb.js - wrapping bberg in js label Aug 26, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 26, 2023
@kevaundray
Copy link
Contributor Author

PR #1577 is a preliminary for the new pedersen implementation

@TomAFrench TomAFrench mentioned this issue May 22, 2024
Merged
TomAFrench added a commit that referenced this issue May 29, 2024
@TomAFrench
chore: stop building/publishing acvm_backend.wasm (#6584)
7a3a491 
Noir no longer makes use of this wasm binary so we don't need to keep
building/publishing it.

Resolves #1832
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 29, 2024
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue May 30, 2024
@TomAFrench @AztecBot
chore: stop building/publishing acvm_backend.wasm (#6584)
cc2a34b 
Noir no longer makes use of this wasm binary so we don't need to keep
building/publishing it.

Resolves AztecProtocol/aztec-packages#1832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bb.js Component: bb.js - wrapping bberg in js
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: stop building/publishing acvm_backend.wasm AztecProtocol/aztec-packages
1 participant
@kevaundray