1090 - noir code should never push a zero nullified_commitment

AztecProtocol · Sep 27, 2023 · 4ee0bfa · 4ee0bfa
1 parent f036a9a
commit 4ee0bfa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/yarn-project/aztec-nr/aztec/src/auth.nr b/yarn-project/aztec-nr/aztec/src/auth.nr
@@ -1,17 +1,18 @@
 use crate::context::{PrivateContext, PublicContext};
 use crate::oracle::compute_selector::compute_selector;
+use crate::constants_gen::EMPTY_NULLIFIED_COMMITMENT;
 
 global IS_VALID_SELECTOR = 0xe86ab4ff;
 global IS_VALID_PUBLIC_SELECTOR = 0xf3661153;
 
 fn assert_valid_message_for(context: &mut PrivateContext, whom: Field, message_hash: Field) {
   let result = context.call_private_function(whom, IS_VALID_SELECTOR, [message_hash])[0];
-  context.push_new_nullifier(message_hash, 0);
+  context.push_new_nullifier(message_hash, EMPTY_NULLIFIED_COMMITMENT);
   assert(result == IS_VALID_SELECTOR, "Message not authorized by account");
 }
 
 fn assert_valid_public_message_for(context: &mut PublicContext, whom: Field, message_hash: Field) {
   let result = context.call_public_function(whom, IS_VALID_PUBLIC_SELECTOR, [message_hash])[0];
-  context.push_new_nullifier(message_hash, 0);
+  context.push_new_nullifier(message_hash, EMPTY_NULLIFIED_COMMITMENT);
   assert(result == IS_VALID_SELECTOR, "Message not authorized by account");
 }
diff --git a/yarn-project/noir-contracts/src/contracts/test_contract/src/main.nr b/yarn-project/noir-contracts/src/contracts/test_contract/src/main.nr
@@ -103,7 +103,7 @@ contract Test {
         let note = DummyNote::new(amount, secretHash);
 
         // Public oracle call to emit new commitment.
-        context.push_new_nullifier(note.get_commitment(), 0);
+        context.push_new_nullifier(note.get_commitment(), EMPTY_NULLIFIED_COMMITMENT);
     }
 
     // Forcefully emits a nullifier (for testing purposes)