1090 - comments

AztecProtocol · Sep 27, 2023 · f036a9a · f036a9a
1 parent d368efe
commit f036a9a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/circuits/cpp/src/aztec3/circuits/kernel/private/common.cpp b/circuits/cpp/src/aztec3/circuits/kernel/private/common.cpp
@@ -125,6 +125,8 @@ void common_validate_read_requests(DummyBuilder& builder,
  */
 void common_validate_arrays(DummyBuilder& builder, PrivateCircuitPublicInputs<NT> const& app_public_inputs)
 {
+    // The following arrays (new_commitments, etc...) are passed to push_array_to_array()
+    // routines which rely on the passed arrays to be well-formed.
     validate_array(builder, app_public_inputs.new_commitments, "New commitments");
     validate_array(builder, app_public_inputs.new_nullifiers, "New nullifiers");
     validate_array(builder, app_public_inputs.nullified_commitments, "Nullified commitments");
@@ -133,7 +135,7 @@ void common_validate_arrays(DummyBuilder& builder, PrivateCircuitPublicInputs<NT
     validate_array(builder, app_public_inputs.new_l2_to_l1_msgs, "New L2 to L1 messages");
     // return_values are not used in private kernel circuit and therefore not validated.
     // encrypted_logs_hash and unencrypted_logs_hash have their own integrity checks.
-    // read_requests are processed through a loop to the whole array and therefore does not
+    // read_requests are processed through a loop over the whole array and therefore do not
     // rely on the array to be right-zero padded.
 }
 

diff --git a/circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_ordering.cpp b/circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_ordering.cpp
@@ -68,10 +68,6 @@ void match_reads_to_commitments(DummyCircuitBuilder& builder,
     }
 }
 
-// TODO(https://github.com/AztecProtocol/aztec-packages/issues/837): optimized based on hints
-// regarding matching a nullifier to a commitment
-// i.e., we get pairs i,j such that new_nullifiers[i] == new_commitments[j]
-
 /**
  * @brief This function matches transient nullifiers to commitments and squashes (deletes) them both.
  *