Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocean heightmap and Scale bar styling change [v1.96] #1045

Merged
merged 15 commits into from
Feb 24, 2024
Merged

Ocean heightmap and Scale bar styling change [v1.96] #1045

merged 15 commits into from
Feb 24, 2024

Conversation

Azgaar
Copy link
Owner

@Azgaar Azgaar commented Feb 12, 2024

Description

Ocean heightmap and Scale bar styling change.

Type of change

  • Bug fix
  • New feature
  • Refactoring / style
  • Documentation update / chore
  • Other (please describe)

Versioning

  • Version is updated
  • Changed files hash is updated

Azgaar and others added 2 commits December 9, 2023 20:01
* feat: style scale bar

* feat: style scale bar - style presets

---------

Co-authored-by: Azgaar <[email protected]>
* feat: allow to render ocean heightmap

* feat: allow to render ocean heightmap - test

* feat: allow to render ocean heightmap - fix issue

* feat: allow to render ocean heightmap - cleanup

---------

Co-authored-by: Azgaar <[email protected]>
@Azgaar Azgaar self-assigned this Feb 12, 2024
@Azgaar Azgaar changed the title Ocean heightmap and Scale bar styling change [V1.96] Ocean heightmap and Scale bar styling change [v1.96] Feb 12, 2024
Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for afmg ready!

Name Link
🔨 Latest commit 8167309
🔍 Latest deploy log https://app.netlify.com/sites/afmg/deploys/65da03dbbe6e3c0008974557
😎 Deploy Preview https://deploy-preview-1045--afmg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Azgaar and others added 13 commits February 13, 2024 00:54
* Add the name of culture and namesbase in the name editor dialog

Added the name of the culture and  namesbase in the dialog "name editor".
This tells information on the "click to generate a culture-specific name"
It tells you the culture before changing name.

* cultureName into cultureId + cultureName

And deleted the incomplete code of showing culture name on datatip

* refactor: leave culture name only

---------

Co-authored-by: Azgaar <[email protected]>
* Added Burgs column to province editor

Added to province editor:
+ Burgs column
+ the number of Burgs, p.burgs.length
+ "icon-dot-circled" to go to overviewBurgs.
+ overviewBurgs Filtered by state id.
+ Fixed some typos.

* fixed code as Azgaar suggested

+ Corrected provincesHeader distance in em.
+ const stateId = pack.provinces[p].state;
- Deleted cell count.

* deleted HTML code for provincesFooter cells

- Deleted Total land cells number HTML from provincesFooter.

* deleting totalCells in the code, maybe i will add provinceCells in the future.

Deleted lines for const totalCells and for (+cells / totalCells) * 100 + "%";

* refactor: cleanup

* refactor: cleanup

---------

Co-authored-by: Azgaar <[email protected]>
@Azgaar Azgaar merged commit 374c21b into master Feb 24, 2024
4 checks passed
@Azgaar Azgaar deleted the v1.96 branch February 24, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants