Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The info on state regiments gets merged or confused when states are merged #1041

Closed
Avengium opened this issue Jan 26, 2024 · 1 comment
Closed
Assignees
Labels

Comments

@Avengium
Copy link
Contributor

When you merge one state with another, the element name and description from the absorbed state change from their respective name and description for that of the first regiment from that state.

So, for example state A (ruling state) merges with state B, then all of regiments from state B change their element name and description for that of the first regiment from state B. Their overall appearance keeps the same, but then if you try to edit the element name or description of one of them, all of them get updated, as if they are the same regiment.

If you are viewing the text note of a regiment and then select the "Element" to view another note, you can see the regiments still are there, but I guess kind of in the backrooms.

Also, color for the regiment base circle doesn't change nor the background of the emoji to represent the regiment.

Expected behavior

When the states get together and one of the states is eliminated, that the remainng state keeps their regiments, as they are, without confusion with previous and new data.

.map file

Collaria. Collaria_2024-01-21-04-17.zip

System

  • Version: 1.95
  • Browser: Google Chrome
  • OS: Microsoft Windows
@Azgaar Azgaar added bug and removed pending review labels Jan 27, 2024
Azgaar pushed a commit that referenced this issue Feb 19, 2024
@Azgaar
Copy link
Owner

Azgaar commented Feb 19, 2024

To be fixed in 1.96

@Azgaar Azgaar closed this as completed in 374c21b Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants