Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hints for mypy 2.1 #1177

Merged
merged 1 commit into from
May 14, 2018
Merged

Fix type hints for mypy 2.1 #1177

merged 1 commit into from
May 14, 2018

Commits on May 11, 2018

  1. Fix type hints for mypy 2.1 

    Closes #1176

Various things I've needed to do:

- In a number of places include that the type is `Optional[]`.
- In a number of places include an `assert` so that `mypy` knows that
  the type is no longer None.
- I have made a minor refactor to the Moran process, I could have used
  asserts but this actually pointed out a spot where I believe the tests
  were incorrect: we were testing a specific situation where
  `MoranProcess.birth` or `MoranProcess.death` should have been called with
  default `index=None` but was actually being tested with `index=0`.
- **I have ignored** a type hint check in `fingerprint.py`: I was
  completely unable to get this one happy

To ensure that any new PRs don't break CI let's merge this under bug fix.
    @drvinceknight
    drvinceknight committed May 11, 2018
    Configuration menu
    Copy the full SHA
    beee0f6 View commit details
    Browse the repository at this point in the history