Fix type hints for mypy 2.1 #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1176 Various things I've needed to do: - In a number of places include that the type is `Optional[]`. - In a number of places include an `assert` so that `mypy` knows that the type is no longer None. - I have made a minor refactor to the Moran process, I could have used asserts but this actually pointed out a spot where I believe the tests were incorrect: we were testing a specific situation where `MoranProcess.birth` or `MoranProcess.death` should have been called with default `index=None` but was actually being tested with `index=0`. - **I have ignored** a type hint check in `fingerprint.py`: I was completely unable to get this one happy To ensure that any new PRs don't break CI let's merge this under bug fix.
marcharper
approved these changes
May 12, 2018
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1176
Various things I've needed to do:
Optional[].assertso thatmypyknows thatthe type is no longer None.
asserts but this actually pointed out a spot where I believe the tests
were incorrect: we were testing a specific situation where
MoranProcess.birthorMoranProcess.deathshould have been called withdefault
index=Nonebut was actually being tested withindex=0.fingerprint.py: I wascompletely unable to get this one happy
To ensure that any new PRs don't break CI let's merge this under bug fix. 👍 :)