E2E tests fix in GB build #95282
Merged
E2E tests fix in GB build #95282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
This reverts commit 1472a47.
matticbot
added
the
[Status] Needs Review
| @@ -68,7 +68,10 @@ export function createBlockTests( specName: string, blockFlows: BlockFlow[] ): v | |||
| const blockHandle = await editorPage.addBlockFromSidebar( | |||
| blockFlow.blockSidebarName, | |||
| blockFlow.blockEditorSelector, | |||
| { noSearch: true, blockFallBackName: blockFlow.blockTestFallBackName } | |||
| { | |||
| noSearch: blockFlow.noSearch === false ? false : true, | |||
There was a problem hiding this comment.
Nitpicky - this works well enough, but I would use null coalescing here:
Suggested change
| noSearch: blockFlow.noSearch === false ? false : true, | |
| noSearch: blockFlow.noSearch ?? true, |
Then, if there's any non-nullish value in noSearch (anything other than null or undefined), it'd be used. Otherwise, it'd default to true. But that's just a preference - explicitly checking for false also works.
rafaelgallani
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
LGTM, the latest commit (c03aa49) fixed the tests.
I can confirm both specs/blocks/blocks__core.ts and specs/blocks/blocks__core-jetpack-extended.ts tests are passing for:
- Simple
- Simple + Edge
- Atomic
- Atomic + Edge
- Atomic + Nightly
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to fixing e2e tests on Gutenberg build https://teamcity.a8c.com/viewLog.html?buildId=13488805
Proposed Changes
"YouTube Embed" block had a fallback named "YouTube", we've removed that to prevent the E2E from selecting the YouTube icon because of that.
Instagram's embed block name should be changed to "Instagram Embed" from "Instagram". As both of these blocks have the same name, I've made the test search in the inserter first using "Instagram embed" so that only the Embedding block remains. And then went with the inserting process.
The actual solution for this Instagram block would be to change the block's name in Gutenberg. So the current fix is a temporary one to enable a faster release. I'll create a PR on GB changing the name of the block later. Then we can remove this workaround.
Why are these changes being made?
Testing Instructions
Pre-merge Checklist