Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed block names with same name as the social icon blocks are causing confusions and also E2E failure #39965

Closed
Imran92 opened this issue Oct 30, 2024 · 1 comment · Fixed by #39970
Assignees
Labels
[Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@Imran92
Copy link
Contributor

Imran92 commented Oct 30, 2024

Impacted plugin

Jetpack

Quick summary

We've recently change the name of YouTube, Twitter etc blocks to YouTube Embed and Twitter Embed, here https://github.com/WordPress/gutenberg/pull/63371/files .

However, the name of the embedding block for Facebook and Instagram has not been changed. Because these two embed blocks are variations of embed blocks added by Jetpack introduced here #17192 .

So it looks confusing for users. Also causd E2E test failures because we couldn't select the correct Embed by name which we temporarily fixed by Automattic/wp-calypso#95282.

To have these properly fixed, we should be changing the name to Instagram Embed so the intention and functionality are more easily understandable.

Insta has two blocks with same name and icon

Image

Facebook has three!

Image

The issue was initially created on the Gutenberg repo. But it turned out to be a Jetpack issue. So we are creating here with more details

Steps to reproduce

  1. Create a fresh simple site
  2. Create a new post
  3. Go to block inserter and search by either Instagram or facebook.

A clear and concise description of what you expected to happen.

Easily understand which one is an Embed block

What actually happened

Multiple blocks with same name

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

@Imran92 Imran92 added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Oct 30, 2024
@Imran92 Imran92 self-assigned this Oct 30, 2024
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Platform] Simple [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack labels Oct 30, 2024
@Imran92 Imran92 changed the title Embed block names with same name as the social icon blocks are causing E2E failure Embed block names with same name as the social icon blocks are causing confusions and also E2E failure Oct 30, 2024
@Robertght
Copy link

@Imran92 I can see you've assigned yourself to this so I'll mark this triaged on our board as well.

@Robertght Robertght moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 30, 2024
@Robertght Robertght added Triaged and removed Needs triage Ticket needs to be triaged labels Oct 30, 2024
@Imran92 Imran92 moved this from Triaged to Needs Review in Automattic Prioritization: The One Board ™ Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended
Development

Successfully merging a pull request may close this issue.

2 participants