-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Status: Add component tests #8128
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import React from 'react'; | ||
import { expect } from 'chai'; | ||
import { shallow } from 'enzyme'; | ||
import identity from 'lodash/identity'; | ||
import Gridicon from 'components/gridicon'; | ||
|
||
describe( 'PostStatus', ( ) => { | ||
let PostStatus; | ||
|
||
before( ( ) => { | ||
PostStatus = require( '..' ).PostStatus; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you can import this at top-of-file now. You'd only have needed it if you had some other test helpers which were prerequisites to be defined before the component itself (e.g. fake DOM, mockery, etc). Should help clean things up a bit. |
||
} ); | ||
|
||
context( 'no post', ( ) => { | ||
it( 'should be empty', ( ) => { | ||
const PostStatusComponent = ( <PostStatus translate={ identity } /> ); | ||
const wrapper = shallow( PostStatusComponent ); | ||
|
||
expect( wrapper ).to.be.empty; | ||
} ); | ||
} ); | ||
|
||
context( 'post', ( ) => { | ||
context( 'sticky', ( ) => { | ||
it( 'should render the primary components', ( ) => { | ||
const PostStatusComponent = ( <PostStatus post={ { sticky: true } } translate={ identity } /> ); | ||
const wrapper = shallow( PostStatusComponent ); | ||
|
||
expect( wrapper ).to.have.descendants( 'span' ); | ||
expect( wrapper ).to.have.className( 'is-sticky' ); | ||
expect( wrapper.childAt( 0 ).is( Gridicon ) ).to.be.true; | ||
expect( wrapper.childAt( 0 ) ).to.have.prop( 'icon', 'bookmark-outline' ); | ||
expect( wrapper.childAt( 1 ) ).to.have.tagName( 'span' ).to.have.text( 'Sticky' ); | ||
} ); | ||
} ); | ||
|
||
context( 'not sticky', ( ) => { | ||
context( 'pending', ( ) => { | ||
it( 'should render the primary components', ( ) => { | ||
const PostStatusComponent = ( <PostStatus post={ { sticky: false, status: 'pending' } } translate={ identity } /> ); | ||
const wrapper = shallow( PostStatusComponent ); | ||
|
||
expect( wrapper ).to.have.descendants( 'span' ); | ||
expect( wrapper ).to.have.className( 'is-pending' ); | ||
expect( wrapper.childAt( 0 ).is( Gridicon ) ).to.be.true; | ||
expect( wrapper.childAt( 0 ) ).to.have.prop( 'icon', 'aside' ); | ||
expect( wrapper.childAt( 1 ) ).to.have.tagName( 'span' ).to.have.text( 'Pending Review' ); | ||
} ); | ||
} ); | ||
|
||
context( 'future', ( ) => { | ||
it( 'should render the primary components', ( ) => { | ||
const PostStatusComponent = ( <PostStatus post={ { sticky: false, status: 'future' } } translate={ identity } /> ); | ||
const wrapper = shallow( PostStatusComponent ); | ||
|
||
expect( wrapper ).to.have.descendants( 'span' ); | ||
expect( wrapper ).to.have.className( 'is-scheduled' ); | ||
expect( wrapper.childAt( 0 ).is( Gridicon ) ).to.be.true; | ||
expect( wrapper.childAt( 0 ) ).to.have.prop( 'icon', 'calendar' ); | ||
expect( wrapper.childAt( 1 ) ).to.have.tagName( 'span' ).to.have.text( 'Scheduled' ); | ||
} ); | ||
} ); | ||
|
||
context( 'trash', ( ) => { | ||
it( 'should render the primary components', ( ) => { | ||
const PostStatusComponent = ( <PostStatus post={ { sticky: false, status: 'trash' } } translate={ identity } /> ); | ||
const wrapper = shallow( PostStatusComponent ); | ||
|
||
expect( wrapper ).to.have.descendants( 'span' ); | ||
expect( wrapper ).to.have.className( 'is-trash' ); | ||
expect( wrapper.childAt( 0 ).is( Gridicon ) ).to.be.true; | ||
expect( wrapper.childAt( 0 ) ).to.have.prop( 'icon', 'trash' ); | ||
expect( wrapper.childAt( 1 ) ).to.have.tagName( 'span' ).to.have.text( 'Trashed' ); | ||
} ); | ||
} ); | ||
|
||
context( 'unhandled status', ( ) => { | ||
it( 'should be empty', ( ) => { | ||
const PostStatusComponent = ( <PostStatus post={ { sticky: false, status: 'wow' } } translate={ identity } /> ); | ||
const wrapper = shallow( PostStatusComponent ); | ||
|
||
expect( wrapper ).to.be.empty; | ||
} ); | ||
} ); | ||
} ); | ||
} ); | ||
} ); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Automattic/wp-calypso/blob/master/docs/coding-guidelines/javascript.md#spacing
Will have to see if we can get an ESLint rule to enforce this.
There's several instances of this through the file.