Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Status: Add component tests #8128

Merged
merged 1 commit into from
Sep 19, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion client/blocks/post-status/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { localize } from 'i18n-calypso';
import Gridicon from 'components/gridicon';
import { getNormalizedPost } from 'state/posts/selectors';

function PostStatus( { translate, post } ) {
export function PostStatus( { translate, post } ) {
if ( ! post ) {
return null;
}
Expand Down Expand Up @@ -56,6 +56,8 @@ function PostStatus( { translate, post } ) {
);
}

PostStatus.displayName = 'PostStatus';

PostStatus.propTypes = {
globalId: PropTypes.string,
translate: PropTypes.func,
Expand Down
90 changes: 90 additions & 0 deletions client/blocks/post-status/test/index.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
/**
* External dependencies
*/
import React from 'react';
import { expect } from 'chai';
import { shallow } from 'enzyme';
import identity from 'lodash/identity';
import Gridicon from 'components/gridicon';

describe( 'PostStatus', ( ) => {
let PostStatus;

before( ( ) => {
Copy link
Contributor

@aduth aduth Sep 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No filler spaces in empty constructs (e.g., {}, [], fn()).

https://github.com/Automattic/wp-calypso/blob/master/docs/coding-guidelines/javascript.md#spacing

Will have to see if we can get an ESLint rule to enforce this.

There's several instances of this through the file.

PostStatus = require( '..' ).PostStatus;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can import this at top-of-file now. You'd only have needed it if you had some other test helpers which were prerequisites to be defined before the component itself (e.g. fake DOM, mockery, etc). Should help clean things up a bit.

} );

context( 'no post', ( ) => {
it( 'should be empty', ( ) => {
const PostStatusComponent = ( <PostStatus translate={ identity } /> );
const wrapper = shallow( PostStatusComponent );

expect( wrapper ).to.be.empty;
} );
} );

context( 'post', ( ) => {
context( 'sticky', ( ) => {
it( 'should render the primary components', ( ) => {
const PostStatusComponent = ( <PostStatus post={ { sticky: true } } translate={ identity } /> );
const wrapper = shallow( PostStatusComponent );

expect( wrapper ).to.have.descendants( 'span' );
expect( wrapper ).to.have.className( 'is-sticky' );
expect( wrapper.childAt( 0 ).is( Gridicon ) ).to.be.true;
expect( wrapper.childAt( 0 ) ).to.have.prop( 'icon', 'bookmark-outline' );
expect( wrapper.childAt( 1 ) ).to.have.tagName( 'span' ).to.have.text( 'Sticky' );
} );
} );

context( 'not sticky', ( ) => {
context( 'pending', ( ) => {
it( 'should render the primary components', ( ) => {
const PostStatusComponent = ( <PostStatus post={ { sticky: false, status: 'pending' } } translate={ identity } /> );
const wrapper = shallow( PostStatusComponent );

expect( wrapper ).to.have.descendants( 'span' );
expect( wrapper ).to.have.className( 'is-pending' );
expect( wrapper.childAt( 0 ).is( Gridicon ) ).to.be.true;
expect( wrapper.childAt( 0 ) ).to.have.prop( 'icon', 'aside' );
expect( wrapper.childAt( 1 ) ).to.have.tagName( 'span' ).to.have.text( 'Pending Review' );
} );
} );

context( 'future', ( ) => {
it( 'should render the primary components', ( ) => {
const PostStatusComponent = ( <PostStatus post={ { sticky: false, status: 'future' } } translate={ identity } /> );
const wrapper = shallow( PostStatusComponent );

expect( wrapper ).to.have.descendants( 'span' );
expect( wrapper ).to.have.className( 'is-scheduled' );
expect( wrapper.childAt( 0 ).is( Gridicon ) ).to.be.true;
expect( wrapper.childAt( 0 ) ).to.have.prop( 'icon', 'calendar' );
expect( wrapper.childAt( 1 ) ).to.have.tagName( 'span' ).to.have.text( 'Scheduled' );
} );
} );

context( 'trash', ( ) => {
it( 'should render the primary components', ( ) => {
const PostStatusComponent = ( <PostStatus post={ { sticky: false, status: 'trash' } } translate={ identity } /> );
const wrapper = shallow( PostStatusComponent );

expect( wrapper ).to.have.descendants( 'span' );
expect( wrapper ).to.have.className( 'is-trash' );
expect( wrapper.childAt( 0 ).is( Gridicon ) ).to.be.true;
expect( wrapper.childAt( 0 ) ).to.have.prop( 'icon', 'trash' );
expect( wrapper.childAt( 1 ) ).to.have.tagName( 'span' ).to.have.text( 'Trashed' );
} );
} );

context( 'unhandled status', ( ) => {
it( 'should be empty', ( ) => {
const PostStatusComponent = ( <PostStatus post={ { sticky: false, status: 'wow' } } translate={ identity } /> );
const wrapper = shallow( PostStatusComponent );

expect( wrapper ).to.be.empty;
} );
} );
} );
} );
} );