Post Status: Add component tests #8128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattm
added
[Status] Needs Review
yoavf
reviewed
Sep 17, 2016
| import useFakeDom from 'test/helpers/use-fake-dom'; | ||
|
|
||
| describe( 'PostStatus', ( ) => { | ||
| useFakeDom(); |
There was a problem hiding this comment.
Seems like we don't actually need this, so this and the matching import can be removed.
yoavf
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
mattm
force-pushed
the
add/post-status-tests
branch
from
5b3e73b to
88c368c
Compare
mattm
added
[Status] Needs Review
yoavf
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
LGTM 👍 |
aduth
reviewed
Sep 26, 2016
| describe( 'PostStatus', ( ) => { | ||
| let PostStatus; | ||
|
|
||
| before( ( ) => { |
There was a problem hiding this comment.
No filler spaces in empty constructs (e.g.,
{},[],fn()).
Will have to see if we can get an ESLint rule to enforce this.
There's several instances of this through the file.
| let PostStatus; | ||
|
|
||
| before( ( ) => { | ||
| PostStatus = require( '..' ).PostStatus; |
There was a problem hiding this comment.
I think you can import this at top-of-file now. You'd only have needed it if you had some other test helpers which were prerequisites to be defined before the component itself (e.g. fake DOM, mockery, etc). Should help clean things up a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the Post Status component as described in #7942.
To test, run
npm run test-client client/blocks/post-status/and verify that all of the tests pass.Additionally, review the Post Status component and ensure that the test covers all of the relevant conditions.