Fix Global Styles on wpcom #40690
Merged
Fix Global Styles on wpcom #40690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Status] Needs Review
|
Caution: This PR has changes that must be merged to WordPress.com |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
oandregal
reviewed
Apr 2, 2020
apps/full-site-editing/full-site-editing-plugin/global-styles/src/dom-updater.js
Outdated
Show resolved
Hide resolved
|
Squeezing a quick pass-by comment in case it's any helpful: code looks fine to me. Thanks for the quick turn-around @noahtallen |
matticbot
removed
the
[Status] Needs Review
5 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
#40489 broke global styles inside the iFrame (changing a font did not change the font inside the preview). This fixes that.
The root cause is that the
<style />element we dynamically update for Global Styles was not appended at the end of the other<style />elements. I'm not quite sure why, but it seems that this script can begin executing before all the style elements have been loaded. So the fix is to wait some time to add the style element. I chose theisEditorReadyselector for this, but there could be a better heuristic. At any rate, this fixes the issue for me.Testing instructions