-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit experimental features in Editing Toolkit #46489
Comments
@Automattic/cylon is this something that you could look into? |
@WunderBart I think we might need to split this across the teams who worked on each area of the codebase since we are really only familiar with
cc @mkaz
cc @nosolosw
cc @Automattic/serenity
cc @p-jackson |
Thanks for mentioning the right folks, @noahtallen! 🙌 I've split this one into separate issues (see updated description) and created a milestone for the ET. I hope this will help organize this task better. |
👋 I've received the pings and would like to understand how can I help here: is it your goal to audit if an unstable/experimental usage is ok or does it need updating based on WordPress 5.6 stabilization task? This is what I can say about the code for Global Styles: apparently, In case the goal was to remove any unstable/experimental API. From what I gathered reading that issue, it looks like the problem was that the stylesheet generated in the client by the Global Styles plugin upon user changes needs to be appended after Gutenberg's own editor styles (which is somehow messed up by the iframed editor). This is what's happening:
A few alternatives that come to mind to get rid of the
|
👋 @nosolosw, thanks for your reply. Our goal is to make sure experimental features don't accidentally break the code that depends on them. This means either providing a fallback mechanism (i.e. like this one) or an alternative implementation as you mentioned. I didn't notice the |
I don't think I can own that refactor but can provide support, pointers to where to start, or reviews if that's helpful to folks. |
Closing this as of #47712 / p4TIVU-9xW-p2 |
Master tracking issue: #44251
Editing Toolkit is dependant on experimental features without a fallback for a scenario where such a feature is not supported anymore. Below is a list of usages that we need to update in this matter:
dotcom-fse
: Audit experimental features in ET/dotcom-fse #46520event-countdown-block
: Audit experimental features in ET/event-countdown-block #46519global-styles
: Audit experimental features in ET/global-styles #46522premium-content
: Audit experimental features in ET/premium-content #46523wpcom-block-editor-nav-sidebar
: Audit experimental features in ET/wpcom-block-editor-nav-sidebar #46524The text was updated successfully, but these errors were encountered: