DocumentHead: Only reset unreadCount
on ROUTE_SET
#25501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variation of #25005 (without requiring #24980).
This is the conclusion of a call with @a8dar and @sirreal, based on previous work and investigation found in #25493 and #23961, etc.
Reverts most of #8224, except for its main objective: to reset
unreadCount
upon route change. However, resetting all the other parts ofdocument-head
(title, meta, and links) turned out to be undesirable found documented in the issues and PRs linked from this PR :)Fixes #24977. Also fixes #23924.
Stealing @a8dar's testing instructions from #25493:
Now reload any of these pages, and verify that the site title is still intact, and that the page source continues to include
canonical
link
s.This finally fixes server-side caching of
document-head
stuff.Potential (but less crucial) follow-ups include #24980 and #25003.