DocumentHead: Remove refreshHeadTags() method #25003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
Framework
[Status] Needs Review
|
It does indeed look like those tags are not rendered anymore, so I don't have any problem with merging this 👍 It's weird that we allowed those tags to not be rendered at some point. Last time we did the switch to redirect |
ockham
added
[Status] Needs Review
ockham
force-pushed
the
remove/document-head-client-side-code
branch
from
d9532d8 to
b0ec732
Compare
tyxla
approved these changes
May 29, 2018
| @@ -131,8 +95,6 @@ DocumentHead.propTypes = { | |||
| export default connect( | |||
| state => ( { | |||
| formattedTitle: getDocumentHeadFormattedTitle( state ), | |||
| allLinks: getDocumentHeadLink( state ), | |||
There was a problem hiding this comment.
These are the only usages of those 2 selectors. We could totally delete them as well!
There was a problem hiding this comment.
Err nope 😄
wp-calypso/server/render/index.js
Lines 177 to 178 in 0b770c9
There was a problem hiding this comment.
We want these in our server-generated HTML, after all 😉
This was referenced Jun 14, 2018
ockham
force-pushed
the
remove/document-head-client-side-code
branch
from
b0ec732 to
04f01dd
Compare
matticbot
removed
the
[Status] Needs Review
dmsnell
added
the
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on #24980. I read through #15297 which introduced this but couldn't make sense of why this method was introduced. (Most of all, adding
metaandlinktags on the client side doesn't seem to make a lot of sense when they're already added on the server side.) I'd be thankful if someone could explain the motivation for adding these methods.My current strategy for fixing SSR is found in #24977. Since SSR is broken anyway right now, I don't assume this PR to have any impact.
Testing instructions: Make sure that Calypso works as before.