Remove payout timing notice and update the help tooltip. #9812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -287 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
brucealdridge
approved these changes
Nov 29, 2024
| */ | ||
| export const DepositTransitDaysNotice: React.FC = () => ( | ||
| <InlineNotice | ||
| icon={ tip } |
There was a problem hiding this comment.
Tip isn't used anymore and can be removed from the import.
There was a problem hiding this comment.
Good catch! Removed in a14783e.
|
I updated the copy per last comment #7900 (comment).
|
jaclync
added a commit
that referenced
this pull request
Dec 3, 2024
* develop: Remove payout timing notice and update the help tooltip. (#9812) Fix styling on payment details page in mobile view. (#9790) Prevent browser error on dispute evidence submission (#9847) Update inquiry order notes to use inquiry specific content (#9828) Restrict Stripe Link to credit card payment method and improve cleanup (#9822)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7900
Changes proposed in this Pull Request
Note: the changes from this PR looks different from what the original issue #7900 explains because there's some discussions there. If there's further discussion, I'll update this PR accordingly.
On the Payments overview page:
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge