Fix styling on payment details page in mobile view. #9790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +201 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
…payments-details-mobile-view' of github.com:Automattic/woocommerce-payments into fix/7230-payments-details-mobile-view
Jinksi
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
This mostly looks good to me @shendy-a8c 🌟
I noticed that this introduced a bit of a glitchy case for ~685px width viewports, when the transaction status is Disputed: needs response. The USD wraps under and the status chip is awkwardly aligned.
develop:
this PR:
Aside from that ☝️ this is looking good on my phone:
Comment on lines
187
to
197
| .dispute-notice-link { | ||
| display: block; | ||
| } | ||
| } | ||
|
|
||
| @media screen and ( max-width: $break-small ) { | ||
| .wcpay-inline-notice.components-notice | ||
| .components-notice__content | ||
| a.dispute-notice-link { | ||
| white-space: normal; | ||
| } |
There was a problem hiding this comment.
⛏️ for consistency, should this new classname follow BEM-naming?
Suggested change
| .dispute-notice-link { | |
| display: block; | |
| } | |
| } | |
| @media screen and ( max-width: $break-small ) { | |
| .wcpay-inline-notice.components-notice | |
| .components-notice__content | |
| a.dispute-notice-link { | |
| white-space: normal; | |
| } | |
| .dispute-notice__link { | |
| display: block; | |
| } | |
| } | |
| @media screen and ( max-width: $break-small ) { | |
| .wcpay-inline-notice.components-notice | |
| .components-notice__content | |
| a.dispute-notice__link { | |
| white-space: normal; | |
| } |
There was a problem hiding this comment.
Addressed in 13db0c1.
Comment on lines
22
to
36
| .payment-details-summary__amount_wrapper { | ||
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
|
||
| @media screen and ( max-width: $break-small ) { | ||
| .payment-details-summary__amount_wrapper { | ||
| flex-direction: column; | ||
| align-items: flex-start; | ||
|
|
||
| .payment-details-summary__status { | ||
| order: -1; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
⛏️ Similarly, for consistency with BEM, I suggest we use - in amount-wrapper rather than _.
Suggested change
| .payment-details-summary__amount_wrapper { | |
| display: flex; | |
| align-items: center; | |
| } | |
| @media screen and ( max-width: $break-small ) { | |
| .payment-details-summary__amount_wrapper { | |
| flex-direction: column; | |
| align-items: flex-start; | |
| .payment-details-summary__status { | |
| order: -1; | |
| } | |
| } | |
| } | |
| .payment-details-summary__amount-wrapper { | |
| display: flex; | |
| align-items: center; | |
| } | |
| @media screen and ( max-width: $break-small ) { | |
| .payment-details-summary__amount-wrapper { | |
| flex-direction: column; | |
| align-items: flex-start; | |
| .payment-details-summary__status { | |
| order: -1; | |
| } | |
| } | |
| } |
There was a problem hiding this comment.
Addressed in 13c3890.
|
Thank four for the review @Jinksi.
I fixed this.
Now it looks better. Before: Screen.Recording.2024-12-03.at.04.02.19.movAfter: Screen.Recording.2024-12-03.at.04.03.30.mov |
jaclync
added a commit
that referenced
this pull request
Dec 3, 2024
* develop: Remove payout timing notice and update the help tooltip. (#9812) Fix styling on payment details page in mobile view. (#9790) Prevent browser error on dispute evidence submission (#9847) Update inquiry order notes to use inquiry specific content (#9828) Restrict Stripe Link to credit card payment method and improve cleanup (#9822)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7230
Changes proposed in this Pull Request
In my local, the pill does not overflow like shown in the screenshot of the original issue.
Before:
After:
I have to re-arrange the elements. I group the transaction amount and currency and move the
PaymentStatusChipandDisputeStatusChip.I also added
classNameprop forPaymentStatusChipandDisputeStatusChipso I can target them in CSS selector.Before:
After:
Testing instructions
Make sure desktop view does not change due to these PR changes.
Make sure in mobile view, the status chips is located at the top.
Make sure desktop view does not change due to these PR changes.
Make sure in mobile view, the status chips is located at the top.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge