Fixed Affirm using black logo on dark themes #9805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpressutto5
requested review from
a team and
timur27
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
@pierorocca Could you test this build and see if it fixes the issue you found? |
|
Size Change: -16 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
@gpressutto5 I'm still seeing inconsistencies.
|
I spent some time looking for a quick fix, but I couldn't find the cause. From what I understand, the logo on the Blocks checkout label, which is the focus of this issue, is now correct, and the error is in the PMME of the product page, and in the Payment Element, right? We can handle items 2 to 5 + Secondary question in #9803. Maybe even the Payment Element part of the first item will be fixed in that. |
|
I don't have the "Available offers" text when I select the payment method. p1732645887236539-slack-CU6SYV31A
|
timur27
approved these changes
Nov 28, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9804
Changes proposed in this Pull Request
The Affirm logo was not updating correctly according to the theme. This PR fixes it by updating the theme after generating the appearance object. We can't use the same fix for shortcode checkout because it is rendered by PHP, so it requires refreshing the page after updating the appearance object.
p1731716238180769-slack-CU6SYV31A
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge