Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMME text color should not be using the label color #9803

Closed
gpressutto5 opened this issue Nov 25, 2024 · 2 comments · Fixed by #9840
Closed

PMME text color should not be using the label color #9803

gpressutto5 opened this issue Nov 25, 2024 · 2 comments · Fixed by #9840
Assignees
Labels
focus: checkout payments priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.

Comments

@gpressutto5
Copy link
Contributor

Describe the bug

In #9621 we fixed the Apparence API not being correctly applied to the PMME, however, we are using the label color as text color for this element. Because the Blocks Checkout uses floating labels, this color might not look good. We should update it to use the text color of a paragraph.

Image

To Reproduce

  1. Use a dark theme, or use CSS to update your background color to a dark color and the text color to a light color.
  2. Do not enable Blocks Checkout dark mode.
  3. Go to the blocks checkout and see the PMME does not look good.

Additional context

p1731716238180769-slack-CU6SYV31A

@gpressutto5 gpressutto5 added the type: bug The issue is a confirmed bug. label Nov 25, 2024
@gpressutto5
Copy link
Contributor Author

gpressutto5 commented Nov 25, 2024

@pierorocca I think this should not be a high-priority ticket as it only looks broken when using a dark theme while not using the Blocks Checkout dark mode.

@pierorocca
Copy link
Contributor

You'd be surprised how many sites do not use dark mode inputs. It's a really hard setting to find and I expect most sites would stick with white input field background.

A reminder to add focus labels when creating bug tickets to trigger the automated workflows for triaging.

@gpressutto5 gpressutto5 added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Nov 25, 2024
@gpressutto5 gpressutto5 self-assigned this Nov 26, 2024
@gpressutto5 gpressutto5 changed the title PMME text color should not is using the label color PMME text color should not be using the label color Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout payments priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants