Decoupled Multi-currency module #9617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hector Lovo <[email protected]>
…-payments into multi-currency-v2
)" This reverts commit af3cc60.
…global function in `RestController` (#9560)
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +901 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
reykjalin
approved these changes
Oct 23, 2024
…-payments into multi-currency-v2
cesarcosta99
approved these changes
Oct 24, 2024
| Significance: minor | ||
| Type: fix | ||
|
|
||
| Provide backwards-compatible method for retrieving the multi-currency instance. |
There was a problem hiding this comment.
I wanted to highlight we have two changelog entries in this PR. If that's intentional, no worries, but I thought it'd be good to bring it up.
There was a problem hiding this comment.
It's intentional. Thanks for flagging. 👍
|
@cesarcosta99 I synced 6792d84 now in this PR. Could you please take a look at this commit before I merge? |
cesarcosta99
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
6792d84 looks good and tests well 👍 Even though it has many LOC changed the changes are straightforward.
- Smoke test multi-currency and single currency settings and a multi-currency transaction ✅
- I searched for old references of
gateway_contextand didn't find any ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: pcrvl0-1iw-p2
Changes proposed in this Pull Request
The purpose of this PR is to merge the feature branch
multi-currency-v2intodevelop. All of the PRs that were previously merged into multi-currency-v2 were tested (pcrvl0-1oD-p2) and code reviewed (36-gh-Automattic/woopayments).Testing instructions
composer dump-autoload.npm run build:client.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge