Decouple MCCY analytics and root folders #9326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +599 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
rafaelzaleski
force-pushed
the
migrate/multi-currency-analytics
branch
from
0f8ddf1 to
eccf524
Compare
rafaelzaleski
force-pushed
the
migrate/multi-currency-analytics
branch
from
eccf524 to
b1b60f8
Compare
6 tasks
…multi-currency-analytics
rafaelzaleski
changed the title
rafaelzaleski
requested review from
a team,
asumaran,
lovo-h and
ricardo
and removed request for
a team and
asumaran
ricardo
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Nice work. I couldn't find any issues in the code despite the large diff. 👍
- ✅ Confirm Full Migration of
./client/multi-currency-analytics. - ✅ Confirm Full Migration of
./client/multi-currency. - ✅ Smoke tested multi currency and single currency settings.
- multi-currency/client/data/actions.js – This was merged previously, I can see the git history.
- multi-currency/client/analytics/index.js – From this PR, I can't see the git history.
ricardo
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 107-gh-Automattic/woopayments.
Changes proposed in this Pull Request
This PR continues the MCCY migration to V2 by migrating the following:
Testing instructions
Confirm Full Migration of `./client/multi-currency-analytics
npm run test:jscommand and ensure all tests pass../client/multi-currency-analyticswere moved to./multi-currency/client/analytics, properly disconnected from WooPayments, properly reconnected into MCCY, and interfaced with WooPayments through the interface later (e.g../multi-currency/interface/*).Confirm Full Migration of `./client/multi-currency
npm run test:jscommand and ensure all tests pass../client/multi-currencywere moved to./multi-currency/client/, properly disconnected from WooPayments, properly reconnected into MCCY, and interfaced with WooPayments through the interface later (e.g../multi-currency/interface/*).npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge