Add support for retrieving gateway-specific saved tokens #8991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
timur27
force-pushed
the
fix/token-retrieval-per-payment-method
branch
from
a9987ec to
bd57bc7
Compare
…into fix/token-retrieval-per-payment-method
timur27
changed the title
timur27
commented
Jun 21, 2024
timur27
requested review from
a team and
FangedParakeet
and removed request for
a team
FangedParakeet
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Code here looks good and can confirm that it resolves the original issue. Followed the testing instructions and did not meet any unanticipated functionality.
once you re-use saved 3DS, you might notice that saved 3DS gets re-saved on the saved tokens list. This behavior occurs in develop and will be covered in
I can confirm that I was also able to replicate the above in both shortcode and blocks checkouts.
Other than that I've left one small comment about code-style, but you can include it at your own discretion. LGTM. 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8476
Changes proposed in this Pull Request
Testing instructions
Shortcode checkout
developand will be covered in Duplicate saving of 3DS card entry after checkout #8997My account
Blocks checkout
Testing the use-case which this PR fixes in the first place
6.4.0or earlierdevelop, navigate to shortcode checkout and confirm that SEPA payment method saved previously is appearing both under credit card and SEPA payment element.fix/token-retrieval-per-payment-methodbranchSave payment information to my account for future purchases.checkbox as well, place the ordernpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge