Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate saving of 3DS card entry after checkout #8997

Closed
timur27 opened this issue Jun 21, 2024 · 1 comment · Fixed by #9679
Closed

Duplicate saving of 3DS card entry after checkout #8997

timur27 opened this issue Jun 21, 2024 · 1 comment · Fixed by #9679
Assignees
Labels
component: checkout Issues related to Checkout focus: checkout payments priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.

Comments

@timur27
Copy link
Contributor

timur27 commented Jun 21, 2024

Describe the bug

After using a saved 3DS card during checkout, it gets re-saved on the store.

To Reproduce

  1. Perform checkout, use a 3DS card, and save it
  2. Checkout again but use the saved 3DS this time
  3. Open the checkout page and you will see the saved 3DS entry is duplicated now

Additional context

This behavior could potentially be related to our recent fixes for saving 3DS cards in 0635be2.

@timur27 timur27 added type: bug The issue is a confirmed bug. component: checkout Issues related to Checkout focus: checkout payments labels Jun 21, 2024
@mdmoore
Copy link
Member

mdmoore commented Jun 21, 2024

This issue is the result of this fix for 3DS subscriptions missing payment methods and failing renewals as a result. Previously, tokens were only added when the payment_method_id was present in the request, which is only the case when saving a payment method. This meant that 3DS payment methods were not stored in subscriptions. The solution was to get the payment_method_id from the intent. This means that now the payment_method_id is always present and 3DS tokens are saved again when paying with a saved 3DS card.

I think rather than just checking for the presence of a payment method id here, we need to check whether the payment method is intended to be saved, indicated either by the save payment method checkbox or when the order is a subscription order.

@pierorocca pierorocca added the priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability label Jun 27, 2024
@gpressutto5 gpressutto5 self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: checkout Issues related to Checkout focus: checkout payments priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants