Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds notice that deposits are paused to Deposits Listing screen #8347
Adds notice that deposits are paused to Deposits Listing screen #8347
Changes from all commits
a2347df
22dfcb5
50a480e
599d01e
42c042e
30d113f
f483236
5537a3f
fd1e1c4
5be2143
0b3a56b
e0edd1b
bdc0cc6
e95fa72
4612891
76593c1
df7ac2b
b9d2ef9
f17120f
63bf836
7d81838
6736b46
58d5d5c
e7d6e62
b9286db
6d349e5
dfc814c
f5a20f3
b522cbc
4375f79
f09b14c
b5392c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can we club the wordpress imports together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason: #8347 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this PR can use a behavior test, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Deposit Listing screen has no test file, will create a issue to add tests for this file, including this functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created issue here #8417
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Maybe we can move this outside the jsx block.
Why?
Deconstructing objects outside the JS block can improve the readability and maintainability of your code. By doing so, you can avoid cluttering the JSX block with lengthy code, making it easier to understand. Additionally, it allows you to reuse the deconstructed values throughout your code, reducing the likelihood of making errors or typos. By keeping your JSX block clean and organized, you can make sure that your code is easier to maintain and update over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are not using any other field from
wcpaySettings.accountStatus
, I feel accessingwcpaySettings.accountStatus.accountLink
just where it's used makes it easier to read. Would reconsider if we had multiple fields being used