Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic test for Deposit List screen (e2e or react unit test) #8417

Open
jessy-p opened this issue Mar 19, 2024 · 1 comment
Open

Add basic test for Deposit List screen (e2e or react unit test) #8417

jessy-p opened this issue Mar 19, 2024 · 1 comment
Labels
component: payouts Issues related to Payouts component: tests Issues related to tests focus: payouts priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: task The issue is an internally driven task (e.g. from another A8c team). type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@jessy-p
Copy link
Contributor

jessy-p commented Mar 19, 2024

Description

As discussed #8347 (comment), create test file for Deposits Listing screen

Acceptance criteria

Tests for Deposits Listing screen, covering the main functionality

Additional context

#8347 (comment)
@jessy-p jessy-p self-assigned this Mar 19, 2024
@jessy-p jessy-p added component: payouts Issues related to Payouts category: engineering For product engineering, architecture work, tech debt and so on. focus: payouts component: tests Issues related to tests and removed category: engineering For product engineering, architecture work, tech debt and so on. labels Mar 19, 2024
@jessy-p jessy-p mentioned this issue Mar 19, 2024
Merged
6 tasks
@haszari haszari changed the title Add tests for Deposits Listing screen Add initial e2e tests for Deposits Listing screen Mar 28, 2024
@haszari haszari changed the title Add initial e2e tests for Deposits Listing screen Add initial e2e test for Deposit List screen Mar 28, 2024
@haszari haszari changed the title Add initial e2e test for Deposit List screen Add initial React unit test for Deposit List screen Mar 28, 2024
@haszari haszari changed the title Add initial React unit test for Deposit List screen Add basic test for Deposit List screen (e2e or react unit test) Mar 28, 2024
@haszari haszari added type: task The issue is an internally driven task (e.g. from another A8c team). type: technical debt This issue/PR represents/solves the technical debt of the project. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. labels May 15, 2024
@haszari
Copy link
Contributor

haszari commented May 15, 2024

Marking as low though it might be better to just close, unless this specific test is more important than other gaps in our test suite.

@jessy-p jessy-p removed their assignment Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: payouts Issues related to Payouts component: tests Issues related to tests focus: payouts priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: task The issue is an internally driven task (e.g. from another A8c team). type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haszari @jessy-p