E2E: fix merchant-orders-full-refund missing order amount (#8319)
#8342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
shendy-a8c
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Looks good. I only looked at the diff and compared it with https://github.com/Automattic/woocommerce-payments/pull/8319/files. Confirmed that GH check E2E Tests - Pull Request / WC - latest | wcpay - merchant is green too.
This process (commit to trunk and this PR brings that commit to develop) feels weird though as it's not usual. Had that commit was made before the 7.3.0 release, it would have been included in the commit that merges trunk to develop ca8c7c0.
It's like an instinct to click that button. Fortunately, I read the PR body first. Scary. |
Co-authored-by: deepakpathania <[email protected]>
|
Another commit has been added to |
@shendy-a8c totally! Although, I hope branch protection would protect us. Next time I might do a cherry-pick rather than |
Jinksi
added a commit
that referenced
this pull request
Mar 28, 2024
…8342) Co-authored-by: Miguel Gasca <[email protected]> Co-authored-by: deepakpathania <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8330
Changes proposed in this Pull Request
Warning
Don't press
Update branchsince we don't wantdevelopcommits pushed totrunkThis PR carries over changes introduced to
trunkvia PR #8319 todevelop.It fixes the
merchant-orders-full-refunde2e test suite by changing the target element used to get the order amount.Testing instructions
E2E Tests - Pull Request / WC - latest | wcpay - merchant (pull_request)merchant-orders-full-refundpasses (see passing test) ✅npm run changelogto add a changelog file, changelog N/A, pulling over a single commitPost merge