-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E: fix merchant-orders-full-refund
missing order amount
#8319
E2E: fix merchant-orders-full-refund
missing order amount
#8319
Conversation
rather than from the merchant order page which is more difficult to parse
merchant-orders-full-refund
missing order amount
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
Requesting a review from Gamma who are the product owners of refund management. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change makes sense and tests are passing, left a small comment but pre-approving for now, so feel free to address it and merge.
tests/e2e/specs/wcpay/merchant/merchant-orders-full-refund.spec.js
Outdated
Show resolved
Hide resolved
…8342) Co-authored-by: Miguel Gasca <[email protected]> Co-authored-by: deepakpathania <[email protected]>
…8342) Co-authored-by: Miguel Gasca <[email protected]> Co-authored-by: deepakpathania <[email protected]>
Fixes #8330
Caution
This PR targets
trunk
which is required to fix e2e tests for server and client repos.Changes proposed in this Pull Request
This PR fixes the
merchant-orders-full-refund
e2e test suite by changing the target element used to get the order amount.Rather than get this amount from the merchant order page which is difficult to parse due to multiple unlabelled
.woocommerce-Price-amount
elements, the amount is instead extracted from the shopper order received page.Testing instructions
E2E Tests - Pull Request / WC - latest | wcpay - merchant (pull_request)
merchant-orders-full-refund
passes ✅npm run changelog
to add a changelog file. Not suitable for a PR direct totrunk
Post merge