Reset Account Management #7914
Merged
Reset Account Management #7914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +886 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
dmallory42
commented
Dec 14, 2023
… for those accounts.
dmallory42
changed the title
…Automattic/woocommerce-payments into dev/3468-allow-reset-account-management
oaratovskyi
reviewed
Dec 20, 2023
There was a problem hiding this comment.
Hi Dan! It works as expected, except I didn't test the last item:
Onboard a new account. At the end of the onboarding, verify the onboarding was successful and the Account Tools are no longer present on the Overview page (because details_submitted = 1)
That's due to PO not working due to slots overfill. I'll be happy to test it once it's working 🙂
client/overview/modal/reset-account/test/__snapshots__/index.test.tsx.snap
Outdated
Show resolved
Hide resolved
|
Thanks for the review, @oaratovskyi!
I tested this scenario and it is working as expected 🙂 : 
|
oaratovskyi
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Thanks for addressing my feedback!
Approving this one and have one last question( it's more about the design side of things, so I leave it to @elizaan36, it's more a curiousity for me):
The underline in Reset Account button - should it be there? The buttons look slightly different now, not sure if that's an issue though
…Automattic/woocommerce-payments into dev/3468-allow-reset-account-management
Thanks for spotting it! Addressed by be1ef8f. |
|
@rogermattic because this is my last day before AFK, and you have some AFK, I'm going to go ahead and merge this one without the design review, since I checked it against your Figma designs. The only difference I can see is that the modal styling is slightly different, but I believe this is because the WP component design for a modal changed fairly recently to a more simplified style. Hope that's okay! If there are any design quirks in what I implemented then I'm happy to make a follow up PR to address them! |
|
Great work, @dmallory42! |
|
Great thanks @dmallory42 ! It looks 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3468
Changes proposed in this Pull Request
details_submitted = 0)Screenshots:
Testing instructions
With Dev Mode Enabled
With Live Mode Enabled
Payments. The account should be restricted and you should be able to see the Account Tools in the account status card.Finish Setup, you should be taken to the Stripe KYC and able to pick up where you left off.Reset Account. First, verify the modal closes via the cancel button andXicon.Reset Accountand then click the confirmation (red button) on the modal. It should delete the account and take you back to the start of the onboarding MOX.details_submitted = 1).npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge