Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Sandbox accounts to be deleted at any moment of the account lifecycle #8132

Closed
Brianmitchtay opened this issue Feb 5, 2024 · 4 comments · Fixed by #8425
Closed

Allow Sandbox accounts to be deleted at any moment of the account lifecycle #8132

Brianmitchtay opened this issue Feb 5, 2024 · 4 comments · Fixed by #8425
Assignees
Labels
component: accounts Issues related to Accounts focus: account lifecycle good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability size: small The issue is sized small. type: developer experience

Comments

@Brianmitchtay
Copy link

Brianmitchtay commented Feb 5, 2024

Description

in #7914 we added the ability for self service account deletion of partially onboarded accounts. This is awesome, full stop.

We can extend this functionality to another use case where users would see great benefit by enabling self service account deletions for all accounts created in sandbox mode given that they will never have live transactions, and users that are testing the platform may want to check many aspects of the account creation process, or creating accounts in various jurisdictions.

Presently, even for accounts created in test mode, if the user wants to clear the fully onboarded account connected to their site, they must contact support.

Acceptance criteria

  • Accounts created in test mode are able to be self service deleted "reset" from a UI option exposed to the end user.
  • This functionality would be limited to testing/sandbox/dev-mode accounts.

Designs

We could very easily re-use the existing design work from the already implemented feature

Testing instructions

  1. Create a new site and add WooPayments
  2. Onboard a new account following the setup directions for sandbox accounts
  3. Return to the Payments > Overview page. You should be able to see the Account Tools section and reset account option, including warning modal, customized for testing accounts
  4. Account is reset so merchant can re-onboard with a live or sandbox account.

Dev notes

Additional context

This request was born from 7690740-zd-a8c where a new-to-woo site builder was surprised this wasn't an option already.

@Brianmitchtay Brianmitchtay added component: accounts Issues related to Accounts needs feedback The issue/PR needs a response from any of the parties involved in the issue. type: developer experience labels Feb 5, 2024
@zmaglica
Copy link
Contributor

zmaglica commented Feb 5, 2024

This issue impacts Onboarding, so assigning to Molters (based on team responsibilities Pc2DNy-3z-p2) @daquinons
Assigning as part of Gamma Triage process PcreKM-yM-p2.

@daquinons
Copy link
Contributor

Hi there @Brianmitchtay! Thank you so much for the proposal :)

Just want to share with you that this is already possible. When. you create a "sandbox account", there is a banner appearing in the "Payments" screen, and also in the settings, that urge you to "set up a live account".
Screenshot 2024-02-06 at 14 03 30
Screenshot 2024-02-06 at 14 03 43

When that "Set up payments" button is pressed, a confirmation modal appears and if confirmed, the sandbox account is deleted and you are redirected back to the first screen of the onboarding (so you can either create a live account or a new sandbox account, as you prefer).

It's true that what I'm referring to is heavily directed to final users and not developers, but the final result is the same here. We've been actively tried to clean up the experience for non-developers, as they were getting confused in some situations (see for example #7974 )

Do you think that after this explanation is there still a need for a new way of accomplishing this?

Again, thank you so much!

@Brianmitchtay
Copy link
Author

Brianmitchtay commented Feb 6, 2024

Thanks for the explanation! @daquinons

I see now that what the merchant wanted to do is possible, but understand why they and I didn’t find it. I think my enhancement request still stands to improve the product by creating a clearer user flow that’s more intuitive for deleting test accounts.

That said, given that we already have a mechanism for this in place, we might be able to address the need with some simple copy changes instead of adding new UI components. Or we could add a "Reset test Account" button/link separately in the same areas with a different modal and text, but have it go to the exact same place.

I'm open to other ideas, but do think that the current flows being very directed at users wanting to set up live accounts is a bit confusing.

@daquinons daquinons added the needs prioritisation Triage finished and issues are ready for the following processing. label Feb 7, 2024
@daquinons daquinons changed the title [Enhancement] Enable Self Service Account reset for Sandbox/testing accounts in any status Allow Sandbox accounts to be deleted at any moment of the account lifecycle Feb 7, 2024
@daquinons
Copy link
Contributor

New requirements for the issue:

  • We need to display the account tool added here Reset Account Management #7914 to sandbox accounts as well
  • We need to modify the copy in both the account tool and the confirmation modal: it needs to be explicit about deleting the sandbox mode account (as you can see in the previous shared PR, currently it's very oriented to the specific use case of live accounts who have not finished onboarding yet)
  • Sandbox accounts can be deleted at any state of the account lifecycle, with our without processed test transactions

@vladolaru vladolaru added priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability and removed needs feedback The issue/PR needs a response from any of the parties involved in the issue. needs prioritisation Triage finished and issues are ready for the following processing. labels Feb 15, 2024
@vladolaru vladolaru added the good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Mar 12, 2024
@anu-rock anu-rock added the size: small The issue is sized small. label Mar 15, 2024
@elazzabi elazzabi self-assigned this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accounts Issues related to Accounts focus: account lifecycle good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability size: small The issue is sized small. type: developer experience
Projects
None yet
7 participants