Fix PSR container conflicts #7525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
htdat
reviewed
Oct 20, 2023
| ! interface_exists( ContainerInterface::class ) | ||
| && isset( $_GET['action'] ) // phpcs:ignore WordPress.Security.NonceVerification.Recommended | ||
| && 'upload-plugin' === $_GET['action'] // phpcs:ignore WordPress.Security.NonceVerification.Recommended | ||
| && 'update.php' === $GLOBALS['pagenow'] |
There was a problem hiding this comment.
Done in c6d4d49
htdat
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7488
Changes proposed in this Pull Request
Previously #7514, but it was reverted.
Testing instructions
Overall, if the container package is in our namespace, and a simple checkout flow works, we should be good.
Specific Testing Instructions for #7488