Fix PSR container conflicts #7514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadoslavGeorgiev
changed the title
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
RadoslavGeorgiev
force-pushed
the
fix/psr-container-conflicts
branch
from
ccfdb1f to
db0f4ca
Compare
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
zmaglica
reviewed
Oct 19, 2023
| @@ -4,7 +4,8 @@ | |||
| "minimum-stability": "dev", | |||
| "require-dev": { | |||
| "league/container": "4.2", | |||
| "coenjacobs/mozart": "0.7.1" | |||
| "coenjacobs/mozart": "0.7.1", | |||
| "psr/container": "^1.1" | |||
There was a problem hiding this comment.
I would replace caret and use a fixed version instead, like "psr/container": "1.1.2"
zmaglica
approved these changes
Oct 19, 2023
naman03malhotra
approved these changes
Oct 19, 2023
| @@ -4,7 +4,8 @@ | |||
| "minimum-stability": "dev", | |||
| "require-dev": { | |||
| "league/container": "4.2", | |||
| "coenjacobs/mozart": "0.7.1" | |||
| "coenjacobs/mozart": "0.7.1", | |||
| "psr/container": "^1.1" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7488
Changes proposed in this Pull Request
Fixes PSR container conflicts by moving
Psr\Containerwithin our namespaceTesting instructions
Overall, if the container package is in our namespace, and a simple checkout flow works, we should be good.
Specific Testing Instructions for #7488
Post merge