Skip merchant dispute e2e tests failing on WC 7.7 #7486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinksi
added
component: disputes
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
shendy-a8c
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Looks good. This PR only skips the failed dispute-related e2e tests. I did not run the e2e-test.yml action because it has been run here.
…ng-respond-now-not-found
Jinksi
deleted the
fix/skip-merchant-dispute-e2e-tests-failing-respond-now-not-found
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR skips merchant dispute e2e tests that fail when running WooCommerce 7.7 in order to explicitly mark the test as broken while a solution is in progress (see issue #7487). Note that this was not caught with PR GH checks (#7448) because the E2E tests - All GH action is not run against every PR.
Skipped tests:
merchant-disputes-save-draft-challenge.spec.jsmerchant-disputes-submit-winning.spec.jsmerchant-disputes-submit-losing.spec.jsThese tests fail on WC 7.7 because the "Respond now" button is not rendered on the edit order screen for WC < 7.9. This is because the disputed order notice requires the hook
woocommerce_admin_order_data_after_payment_infothat was added in WC 7.9 (changelog entry).Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge