Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merchant dispute e2e tests fail when running on WooCommerce 7.7 #7487

Closed
Jinksi opened this issue Oct 15, 2023 · 0 comments · Fixed by #7493
Closed

Merchant dispute e2e tests fail when running on WooCommerce 7.7 #7487

Jinksi opened this issue Oct 15, 2023 · 0 comments · Fixed by #7493
Assignees
Labels
category: e2e Issues and PRs related to e2e tests. component: disputes Issues related to Disputes component: tests Issues related to tests type: bug The issue is a confirmed bug.

Comments

@Jinksi
Copy link
Member

Jinksi commented Oct 15, 2023

Describe the bug

Merchant dispute e2e tests fail when running WooCommerce 7.7. This caused the GH workflow E2E tests - All to fail before tests were skipped (#7486) in order to explicitly mark the test as broken while a solution is in progress (this issue).

Skipped tests:

  • merchant-disputes-save-draft-challenge.spec.js
  • merchant-disputes-submit-winning.spec.js
  • merchant-disputes-submit-losing.spec.js

These tests fail on WC 7.7 because the "Respond now" button is not rendered on the edit order screen for WC < 7.9. This is because the disputed order notice requires the hook woocommerce_admin_order_data_after_payment_info that was added in WC 7.9 (changelog entry).

Note

Keep in mind that we need to keep tests for the flow Order Screen Dispute Notice → Dispute Details, so we should ensure this flow continues to be included in e2e tests for WC v7.9+.

To Reproduce

  1. Un-skip the e2e tests mentioned above.
  2. Run e2e tests with WC 7.7
    1. This can be done in a local environment or by,
    2. Running the GH action "E2E tests - All" against a branch that has un-skipped the tests listed above.

Additional context

@Jinksi Jinksi added type: bug The issue is a confirmed bug. component: disputes Issues related to Disputes component: tests Issues related to tests category: e2e Issues and PRs related to e2e tests. labels Oct 15, 2023
@Jinksi Jinksi self-assigned this Oct 17, 2023
@haszari haszari changed the title Merchant dispute e2e tests fail with WC 7.7 Merchant dispute e2e tests fail when running on WooCommerce 7.7 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: e2e Issues and PRs related to e2e tests. component: disputes Issues related to Disputes component: tests Issues related to tests type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant