Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WooPay 'Save my info' spacing #7405

Merged
merged 6 commits into from
Oct 13, 2023
Merged

fix: WooPay 'Save my info' spacing #7405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d98ca0a
fix: WooPay 'Save my info' spacing
frosso Oct 6, 2023
19b4f48
better, maybe
frosso Oct 6, 2023
d0774e5
Merge branch 'develop' into fix/woopay-save-my-info-styles
frosso Oct 11, 2023
83c074c
Merge branch 'develop' into fix/woopay-save-my-info-styles
frosso Oct 12, 2023
c46919f
Merge branch 'develop' into fix/woopay-save-my-info-styles
mdmoore Oct 12, 2023
7bf94f7
Merge branch 'develop' into fix/woopay-save-my-info-styles
frosso Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/fix-woopay-save-my-info-styles
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

Fix WooPay Same My Info adding unnecessary spacing to checkout
20 changes: 15 additions & 5 deletions client/settings/phone-input/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,21 @@
display: flex;
flex-direction: column;
gap: $gap;
margin-top: $gap-large;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This margin was applied even when the "save my info" container didn't have any content.


&:empty {
margin-top: 0 !important;
margin-bottom: 0 !important;
}

&:not( :empty ) {
#payment .wc_payment_methods.payment_methods.methods + & {
margin-top: $gap-large;

+ .place-order {
margin-top: $gap-large;
}
}
}

h3 {
margin-bottom: 0;
Expand Down Expand Up @@ -106,10 +120,6 @@
.save-details-form.place-order {
margin-top: $gap-smaller;
}

.woopay-save-new-user-container + .place-order {
margin-top: $gap-large !important;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing uncommented !important is always good.

}
}

// compulsary overrides required for intl-tel-input
Expand Down
Loading