fix: WooPay 'Save my info' spacing #7405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frosso
commented
Oct 6, 2023
| @@ -6,7 +6,21 @@ | |||
| display: flex; | |||
| flex-direction: column; | |||
| gap: $gap; | |||
| margin-top: $gap-large; | |||
There was a problem hiding this comment.
This margin was applied even when the "save my info" container didn't have any content.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
frosso
commented
Oct 6, 2023
| @@ -106,10 +115,6 @@ | |||
| .save-details-form.place-order { | |||
| margin-top: $gap-smaller; | |||
| } | |||
|
|
|||
| .woopay-save-new-user-container + .place-order { | |||
| margin-top: $gap-large !important; | |||
There was a problem hiding this comment.
Removing uncommented !important is always good.
|
Size Change: +139 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
frosso
requested review from
a team and
mdmoore
and removed request for
a team
RadoslavGeorgiev
pushed a commit
that referenced
this pull request
Oct 13, 2023
Co-authored-by: Mike Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
I noticed that WooPay's "Save my info" addins unnecessary spacing (via margins) to the checkout pages when no content is displayed.
As good citizens of the checkout pages, fixing to ensure consistent behavior compared to when WooPay is disabled or not available.
Cannot be tested via UTs.
Before/After - WooPay disabled - spacing is consistent:
Before - no payment method needed - "Save my info" is adding a margin-top:
Before - non-CC payment method is selected (or existing WooPay user is being used) - "Save my info" is adding a margin-top:
After - non-CC payment method is selected - "Save my info" is no longer adding a margin-top:
Before/After - CC Payment method is selected:
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge