Determine the proper setting for split UPE to work with WooPay #6828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timur27
force-pushed
the
fix/split-upe-with-woopay-and-multiple-pms
branch
from
d623ec2 to
89c207f
Compare
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
FangedParakeet
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Can confirm the original issue and that this is indeed resolving it. ✅
Was the root cause of this because the JS config was being overwritten when rendering the payment fields for UPE payment methods? 🤔 If so, maybe we should think about refactoring this in the future, so that like the hooks these global variables are only appended to the page once, to ensure there aren't any more unintended side-effects in the future.
That being said, for now, LGTM. 👍
Yes. This field is now supposed to base only on the card gateway since the flag for non-card gateways was separately added in #6656. I agree the refactor is needed in this area at some point. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6730
Changes proposed in this Pull Request
This PR ensures that for the legacy card gateway in the split UPE, the correct flag is provided to the client side so that the proper Stripe account is used, depending on whether the WooPay is enabled or disabled. Due to the nature of rolling out scripts, we ended up overriding the proper
forceNetworkSavedCardsvalue with the UPE gateway, which was rolled out as the second and could never use WooPay, leading the flag having the value offalsealways.Testing instructions
giropayor similar and confirm the successful purchaseCheckout to
develop, perform steps 1-4 from above and confirm that instead of the fifth successful step, a user is seeingError: No such PaymentMethod: 'pm_${ID}'.Blocks checkout isn't affected, but making a single purchase and confirming it works will be appreciated.
Perform steps 1-5 for the legacy card gateway and steps 1-6 for the deferred intent creation UPE gateway. Also, sanity checks the legacy UPE checkout by performing steps 1-6 excluding step 2.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge