WooPay compatibility with deferred intent creation UPE #6656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +4 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
…heckout service tests
Comment on lines
+1360
to
+1366
| if ( ! empty( $upe_payment_method ) && 'woocommerce_payments' !== $upe_payment_method ) { | ||
| $payment_methods = [ str_replace( 'woocommerce_payments_', '', $upe_payment_method ) ]; | ||
| } elseif ( WC_Payments_Features::is_upe_split_enabled() || WC_Payments_Features::is_upe_deferred_intent_enabled() ) { | ||
| $payment_methods = [ 'card' ]; | ||
| } else { | ||
| $payment_methods = WC_Payments::get_gateway()->get_payment_method_ids_enabled_at_checkout( null, true ); | ||
| } |
There was a problem hiding this comment.
It always confuses me how this conditional logic here works...but I'm pretty sure it does and I suppose that's what's important lol. 😂
There was a problem hiding this comment.
Yes, I see what you mean. In this PR, I just moved this logic from the process_payment_for_order method without any modification. I did so to be able to re-use it properly. Overall, this method needs a re-visit, most probably during split-upe/legacy-upe cleanup.
FangedParakeet
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
LGTM!
Finally managed to test this properly: ran it through both the shortcode and blocks checkouts using as many permutations of regular product, subscription, and free-trial subscriptions using multiple accounts with regular payment methods and 3DS payment methods requiring additional authentication and I could not get this implementation to either bend nor break. Nice one! Tip top tidy job. 
|
@FangedParakeet Thanks for your review! Today I've added one more commit (3af7500), which ensures that payment methods addition under My account page works appropriately for the deferred intent UPE. I'd appreciate it if you could take a look at this commit - if everything's alright, please approve the PR once more - this will signal me that we're ready to merge. Thanks! |
FangedParakeet
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Nice catch! It looks like we're now supplying all the valid parameters whenever that Payment Information is required. LGTM.
Spent a bit of time testing pre-existing split-UPE checkout flows, just for my own sanity, and everything appears to be running as expected. Double-checking the code, I don't believe there's anything in here that would conflict with any existing flows in any other gateways, so I think we're good to go now! 🚢
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6291
Changes proposed in this Pull Request
Currently, split UPE with the deferred intent creation on the server is implemented in all flows, including shortcode & Blocks checkout and My account subpages, such as Payment methods, Subscriptions, Pay for order. The time has come for the WooPay to be compatible with this UPE type as well, thus this PR ensures that WooPay's functionality previously used only in pair with the legacy card gateway, is now entirely usable with the deferred intent creation UPE as well.
Testing instructions
1️⃣
https://dashboard.stripe.com/test/customers), confirm that the user is also listed.Now, since you have the user registered in WooPay, check the following:
2️⃣
000000make sure you're redirected successfully to the checkout page with all the cart details.http://host.docker.internal:8090/account/ordersand confirm that the order placed is listed there.Place an order with WooPay in the incognito window.
On the cart page, use the WooPay express checkout button and provide the email in the WooPay to checkout using WooPay. Confirm that the checkout went successfully.
On the product page (e.g. a Beanie) use the express checkout button to test new user registration flow and checking out using the existing email address.
Perform testing instructions from 1️⃣ and 2️⃣ on the Blocks checkout page.
class-checkout-service.phpwas extended a bit. Below are the changes and how to test them (and changes inclass-payment-informationas well):create_intention_requestmethod is used for all the legacy card payments and card payments within the deferred intent creation. This means, that you will probably have this method tested after all the above steps but if still unsure - just enable legacy gateway (non-UPE) or deferred intent UPE and purchase any product with a card.create_and_confirm_setup_intention_requestwas slightly modified as well. To test it out, enable legacy gateway (non-UPE) or deferred intent creation UPE, and purchase a free trial subscription. Ensure that the payment was processed successfully.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge