Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greenseed: fix images #8123

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Greenseed: fix images #8123

merged 1 commit into from
Sep 17, 2024

Conversation

MaggieCabrera
Copy link
Contributor

Changes proposed in this Pull Request:

The images needed renaming when we renamed the theme.

I still need to scroll to see the images when on the site editor. I'm unsure if this si an editor bug or if it's intended, in the frontend we do see the images without having to scroll down.

Related issue(s):

#8102

@MaggieCabrera MaggieCabrera linked an issue Sep 13, 2024 that may be closed by this pull request
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Greenseed.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@iamtakashi
Copy link
Contributor

The rename solves #8102. Thanks @MaggieCabrera. I'll investigate what's happening in the editor in #8107.

@iamtakashi iamtakashi merged commit b671c74 into trunk Sep 17, 2024
2 checks passed
@iamtakashi iamtakashi deleted the fix-greenseed branch September 17, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Greenseed: Broken images
2 participants