Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DotCom Launch]: Greenseed #8107

Open
2 of 4 tasks
MaggieCabrera opened this issue Sep 12, 2024 · 4 comments
Open
2 of 4 tasks

[DotCom Launch]: Greenseed #8107

MaggieCabrera opened this issue Sep 12, 2024 · 4 comments
Assignees

Comments

@MaggieCabrera
Copy link
Contributor

MaggieCabrera commented Sep 12, 2024

DotCom launch checklist

  • Create demo site
  • Create theme showcase
  • Network activate
  • Launch theme

The demo site has been created but the theme has been renamed (old Farmhouse), we need to delete the old one and activate the new one

@alaczek
Copy link
Contributor

alaczek commented Sep 13, 2024

This issue is a blocker for launch: #8102

@iamtakashi
Copy link
Contributor

iamtakashi commented Sep 17, 2024

#8102 fixes the missing image issue, and everything looks good on the front of the site. But, in the editor, the images are still down the page initially, and I think we'll need to fix it before launching it.

The trick the theme does is the group block with a custom CSS class overlay has an absolute positioning. That makes the wrapper's height (the group block with a sticky positioning) is zero, and everything else below comes at the top of the browser. That works well on the front of the site, but not in the editor at the moment.

Is there a way to add a custom style position: absolute; to the Stack block that has the overlay class in the editor like simulated in the screenshot?

CleanShot 2024-09-17 at 19 17 00@2x

@iamtakashi
Copy link
Contributor

@iamtakashi
Copy link
Contributor

There doesn't seem to be a way to fix it with the current approach. I'll work on the theme differently to achieve the effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants