Blockbase children: update comments block #6153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
force-pushed
the
blockbase-children-comments-block
branch
from
a76a97f to
bd9629b
Compare
pbking
added a commit
that referenced
this pull request
Jul 20, 2022
Refactor/blockbase color admin (#6043) Moved templates from old folder location to new (#6073) Blockbase: Implement the Button elements API (#6041) Blockbase: Implement Comment Block and removed CSS (#6080) Fix/migrate blockbase font self hosted (#6123) Blockbase children: update comments block (#6153) Blockbase: Changed the trigger to render social icons (#6079) Blockbase: move button padding styles from ponyfill to theme.json (#5901) Co-authored-by: Grant Kinney <[email protected]> Co-authored-by: Jeremy Yip <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: madhusudhand <[email protected]>
Merged
|
Closing: Work merged in #6167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This is a follow up on #6080 and it's built on top of it. It should be merged right after #6080 to avoid much disruption when the CSS is removed. The loss of that CSS will not result on a broken site, it will simply show the default styling of the old Comment block, so I think it's not terrible for other users of the theme that may take longer to adopt this change if they are already overriding the templates that have the block on it.
@Automattic/serenity heads up on this change and Blockbase's too, for any premium themes that may need it.
Screenshot from Quadrat black: